Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix the error of opSupportLimits for split op #776

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Oct 30, 2024

Fixes #775


Preview | Diff

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/cc @philloooo

@huningxin huningxin requested a review from fdwr October 30, 2024 00:51
@BruceDai BruceDai changed the title Fix the error of opSupportLimits for split op Bugfix: Fix the error of opSupportLimits for split op Oct 30, 2024
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr merged commit 395d07b into webmachinelearning:main Oct 30, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 30, 2024
SHA: 395d07b
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The split's opSupportLimits should be of MLSplitSupportLimits
3 participants