Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MLBuffer => MLTensor #753

Closed
bbernhar opened this issue Aug 20, 2024 · 3 comments
Closed

Rename MLBuffer => MLTensor #753

bbernhar opened this issue Aug 20, 2024 · 3 comments

Comments

@bbernhar
Copy link

The recent revision of the proposed MLBuffer spec no longer represents a low-level concept of device memory storage, as these buffers are now tied to specific shapes and data types. Converting between MLBuffer(s) of different sizes will likely require copying (vs reinterpret_cast). To avoid confusion with other 'buffer-as-bytes' types (e.g., GPUBuffer, ArrayBuffer), I propose renaming MLBuffer to MLTensor.

👍 = I vote yes to rename

@a-sully
Copy link
Contributor

a-sully commented Aug 20, 2024

SGTM. I've been drafting an explainer for MLBuffer and the first sentence is:

This explainer proposes an MLBuffer interface which represents a tensor...

I'll find-and-replace and put up the MLTensor explainer shortly :D

@a-sully
Copy link
Contributor

a-sully commented Sep 10, 2024

MLBuffer never made it into the spec, so the only artifacts saying "MLBuffer" are issues and PRs (and lots of Chromium code which @bbernhar has been diligently refactoring). We could retitle issues including MLBuffer. The explainer PR already uses MLTensor. Otherwise... I think we can close this? :)

@bbernhar
Copy link
Author

I think we can close this? :)

SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants