Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #713: DOMString to USVString #715

Merged

Conversation

zolkis
Copy link
Collaborator

@zolkis zolkis commented Jun 29, 2024

Fixes #713 : trivial replacement of DOMString (names) with USVString.


Preview | Diff

Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fdwr fdwr requested a review from huningxin July 1, 2024 20:51
@inexorabletash
Copy link
Member

FYI: If you put "fixes #nnn" in the PR description (not the title) it'll get cross- linked automatically and resolve the issue automatically when merged. Just noting that here because I was surprised it hadn't happened.

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huningxin huningxin merged commit 3a916f2 into webmachinelearning:main Jul 5, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jul 5, 2024
SHA: 3a916f2
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zolkis zolkis deleted the zk-fix-domstring-usvstring branch November 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use USVString for operand name
4 participants