Prevent Bind Group Error with Zero Triangles #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed format with |
greggman
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for this great sample! This quick fix allocates at least one triangle’s space in the uniform buffer, avoiding the “Uncaptured error: GPUDevice.createBindGroup: entrySize == 0 or entrySize(24) + entryOffset(0) > buffer size(4) or layoutBinding->minBindingSize(20) > entrySize(24)” when numTriangles is 0 on iPadOS 18.5 (with feature flag enabled). It is quite easy to set to zero, so the error is easily triggered, and I guess users might want to set it to zero (initially, I thought of setting the minimum to one; however, this also provides some statistics, just in case). Thank you very much in advance! If any changes would make this PR more suitable, please let me know, and I can adjust.