Add type checking via Deno

tools/.vscode/extensions.json

@@ -0,0 +1,3 @@
+{
+  "recommendations": ["denoland.vscode-deno"]
+}

tools/.vscode/settings.json

@@ -4,7 +4,5 @@
     "inspector/promises",
     "inspector"
   ],
-  "files.watcherExclude": {
-    "**/node_modules/**": true,
-  },
+  "deno.enable": true
 }

tools/deno.json

@@ -0,0 +1,29 @@
+{
+  "workspace": [
+    "./packages/bench",
+    "./packages/mini-parse",
+    "./packages/wesl",
+    "./packages/wesl-link",
+    "./packages/wesl-packager",
+    "./packages/wesl-plugin",
+    "./packages/wesl-reflect",
+    "./packages/wesl-tooling"
+  ],
+  "exclude": [
+    "./examples",
+    "./scripts",
+    "packages/plugin-test",
+    "packages/random_wgsl",
+    "packages/test_pkg",
+    "**/dist/**"
+  ],
+  "compilerOptions": {
+    "lib": ["deno.ns", "dom"],
+    "types": ["@webgpu/types"]
+  },
+  "lint": {
+    "rules": {
+      "exclude": ["no-explicit-any"]
+    }
+  }
+}

tools/packages/bench/deno.json

@@ -0,0 +1 @@
+{}

tools/packages/bench/src/LoadSimpleTest.ts

@@ -1,3 +1,4 @@
+import { exit } from "node:process";
 import * as simpleTests from "../src/experiments/SimpleTests.ts";
 import { loadBenchmarkFiles } from "../src/LoadBenchmarks.ts";
 
@@ -9,7 +10,7 @@ export interface SimpleTest {
 export function loadSimpleTest(simpleSelect: string | undefined): SimpleTest {
   if (!simpleSelect) {
     console.error("No test name prefix provided for --simple");
-    process.exit(1);
+    exit(1);
   }
 
   const testEntry = Object.entries(simpleTests).find(([name]) =>
@@ -21,7 +22,7 @@ export function loadSimpleTest(simpleSelect: string | undefined): SimpleTest {
       `No test found with prefix '${simpleSelect}' in SimpleTests.ts`,
     );
     console.error(`Available tests: ${Object.keys(simpleTests).join(", ")}`);
-    process.exit(1);
+    exit(1);
   }
   const [name, fn] = testEntry;
   return { name, fn };

tools/packages/bench/src/experiments/BenchManually.ts

@@ -1,3 +1,4 @@
+import * as process from "node:process";
 import { _linkSync, type link } from "wesl";
 import type { BenchTest } from "../../bin/bench.ts";
 import { diffPercent } from "../table-util/Formatters.ts";
@@ -7,8 +8,8 @@ export function benchManually(
   tests: BenchTest[],
   baselineLink: typeof link,
 ): void {
-  const gc = globalThis.gc || (() => {});
-  console.log("gc is", globalThis.gc ? "enabled" : "disabled");
+  const gc = (globalThis as any).gc || (() => {});
+  console.log("gc is", (globalThis as any).gc ? "enabled" : "disabled");
   for (const test of tests) {
     const weslSrc = Object.fromEntries(test.files.entries());
     const rootModuleName = test.mainFile;

tools/packages/bench/src/mitata-util/MitataBench.ts

@@ -1,4 +1,5 @@
 import { type PerformanceEntry, PerformanceObserver } from "node:perf_hooks";
+import * as process from "node:process";
 import type * as mitataCountersType from "@mitata/counters";
 import { measure } from "mitata";
 import {
@@ -156,7 +157,7 @@ async function getHeapFn(): Promise<() => number> {
 
 /** fetch the runtime's function to call gc() manually */
 function gcFunction(): () => void {
-  const gc = globalThis.gc || (globalThis as any).__gc;
+  const gc = (globalThis as any).gc || (globalThis as any).__gc;
   if (gc) return gc;
   console.warn(
     "MitataBench: gc() not available, run node/bun with --expose-gc",
@@ -188,6 +189,6 @@ function analyzeGCEntries(
   return { inRun, before, after, total, collects };
 }
 
-async function wait(msec = 0): Promise<void> {
+function wait(msec = 0): Promise<void> {
   return new Promise(resolve => setTimeout(resolve, msec));
 }

tools/packages/bench/src/mitata-util/MitataStats.ts

@@ -1,3 +1,4 @@
+// @ts-types="./Mitata.d.ts"
 import type { CpuCounts } from "@mitata/counters";
 import type { MeasureResult } from "./MitataBench.ts";
 import { mapValues } from "./Util.ts";

tools/packages/mini-parse/deno.json

@@ -0,0 +1 @@
+{}

tools/packages/mini-parse/src/stream/CachingStream.ts

@@ -38,7 +38,7 @@ class Cache<K, V> extends Map<K, V> {
     this.max = max;
   }
 
-  set(k: K, v: V): this {
+  override set(k: K, v: V): this {
     if (this.size > this.max) {
       const first = this.keys().next().value;
       if (first) this.delete(first);

tools/packages/mini-parse/src/test/RegexMatchers.test.ts

@@ -1,5 +1,5 @@
 import { expect, test } from "vitest";
-import { RegexMatchers } from "../stream/MatchersStream";
+import { RegexMatchers } from "../stream/MatchersStream.ts";
 
 test("token matcher", () => {
   const m = new RegexMatchers({

tools/packages/wesl-link/deno.json

@@ -0,0 +1 @@
+{}

tools/packages/wesl-link/src/cli.ts

@@ -1,4 +1,5 @@
 import path from "node:path";
+import { cwd } from "node:process";
 import { pathToFileURL } from "node:url";
 import { enableTracing, log } from "mini-parse";
 import { astToString, link, scopeToString } from "wesl";
@@ -70,7 +71,7 @@ async function parseArgs(args: string[]) {
 
 async function linkNormally(argv: CliArgs): Promise<void> {
   const { baseDir, projectDir, rootModule: rootModuleName } = argv;
-  const weslRoot = baseDir || process.cwd();
+  const weslRoot = baseDir || cwd();
   const weslSrc = await loadModules(projectDir, weslRoot, argv.src);
   const projectDirAbs = path.resolve(projectDir, "src.js");
   const projectDirUrl = pathToFileURL(projectDirAbs);

tools/packages/wesl-link/src/main.ts

@@ -1,7 +1,8 @@
 #!/usr/bin/env node
+import { argv } from "node:process";
 import { hideBin } from "yargs/helpers";
 import { cli } from "./cli.ts";
 
-const rawArgs = hideBin(process.argv);
+const rawArgs = hideBin(argv);
 
 cli(rawArgs);

tools/packages/wesl-packager/deno.json

@@ -0,0 +1 @@
+{}

tools/packages/wesl-packager/src/PackageWesl.ts

@@ -4,6 +4,8 @@ import path from "node:path";
 import { Biome, Distribution } from "@biomejs/js-api";
 import { noSuffix, type WeslBundle } from "wesl";
 import { loadModules, parseDependencies, zip } from "wesl-tooling";
+// Ideally this would use an import attribute instead of this Vite+Deno bodge
+// @ts-types="vite/client"
 import weslBundleDecl from "../../wesl/src/WeslBundle.ts?raw";
 import type { CliArgs } from "./PackagerCli.ts";
 

tools/packages/wesl-plugin/deno.json

@@ -0,0 +1,3 @@
+{
+  "exclude": ["test/**"]
+}

tools/packages/wesl-plugin/src/plugins/farm.ts

@@ -1,4 +1,4 @@
 import { createFarmPlugin } from "unplugin";
-import { weslPlugin } from "../WeslPlugin";
+import { weslPlugin } from "../WeslPlugin.ts";
 
 export default createFarmPlugin(weslPlugin);

tools/packages/wesl-plugin/src/plugins/nuxt.ts

@@ -1,7 +1,7 @@
 import { addVitePlugin, addWebpackPlugin, defineNuxtModule } from "@nuxt/kit";
-import type { WeslPluginOptions } from "../WeslPluginOptions";
-import vite from "./vite";
-import webpack from "./webpack";
+import type { WeslPluginOptions } from "../WeslPluginOptions.ts";
+import vite from "./vite.ts";
+import webpack from "./webpack.ts";
 import "@nuxt/schema";
 
 type ModuleOptions = WeslPluginOptions;

tools/packages/wesl-reflect/deno.json

@@ -0,0 +1 @@
+{}

tools/packages/wesl-reflect/src/types.d.ts

@@ -1,4 +1,8 @@
 /** @hidden */
 declare module "*?simple_reflect" {
-  export const structs: WeslStruct[];
+  /**
+   * Need to put the import here for it to augment the global scope
+   * https://stackoverflow.com/a/51114250/3492994
+   */
+  export const structs: import("./SimpleReflectExtension.ts").WeslStruct[];
 }

tools/packages/wesl-reflect/vitest.config.ts

@@ -2,7 +2,7 @@
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import type { UserConfig } from "vite";
-import viteWesl from "../wesl-plugin/src/plugins/vite";
+import viteWesl from "../wesl-plugin/src/plugins/vite.ts";
 import { simpleReflect } from "./src/SimpleReflectExtension.ts";
 
 const thisPath = fileURLToPath(import.meta.url);

tools/packages/wesl-tooling/deno.json

@@ -0,0 +1 @@
+{}

tools/packages/wesl-tooling/test/ParseDependencies.test.ts

@@ -1,7 +1,7 @@
 import { expect, test } from "vitest";
 import { parseDependencies } from "../src/ParseDependencies.ts";
 
-const thisDir = import.meta.dirname;
+const thisDir = import.meta.dirname!;
 
 test("parseDepenencies finds non-root dependency", () => {
   const srcs = {

tools/packages/wesl/deno.json

@@ -0,0 +1 @@
+{}

tools/packages/wesl/src/ClickableError.ts

@@ -75,7 +75,7 @@ export function throwClickableError(params: ClickableErrorParams): void {
   let oldLimit = 0;
   // Supported on Chrome https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stackTraceLimit
   if ("stackTraceLimit" in Error) {
-    oldLimit = Error.stackTraceLimit;
+    oldLimit = Error.stackTraceLimit as any as number;
     Error.stackTraceLimit = 1;
   }
 

tools/packages/wesl/src/LinkedWesl.ts

@@ -1,7 +1,7 @@
 import type { SrcMap } from "mini-parse";
 import { assertThatDebug } from "./Assertions.ts";
 import { errorHighlight, offsetToLineNumber } from "./Util.ts";
-import type { WeslDevice } from "./WeslDevice";
+import type { WeslDevice } from "./WeslDevice.ts";
 
 /** Results of shader compilation. Has {@link WeslGPUCompilationMessage}
  * which are aware of the WESL module that an error was thrown from. */
@@ -109,7 +109,7 @@ export class LinkedWesl {
     compilationInfo: GPUCompilationInfo,
   ): WeslGPUCompilationInfo {
     return {
-      __brand: compilationInfo.__brand,
+      __brand: "GPUCompilationInfo",
       messages: compilationInfo.messages.map(v =>
         this.mapGPUCompilationMessage(v),
       ),
@@ -134,7 +134,7 @@ export class LinkedWesl {
     );
 
     return {
-      __brand: message.__brand,
+      __brand: "GPUCompilationMessage",
       type: message.type,
       message: message.message,
       offset: srcPosition.position,

tools/packages/wesl/src/WeslDevice.ts

@@ -1,5 +1,5 @@
 import { throwClickableError } from "./ClickableError.ts";
-import type { ExtendedGPUValidationError } from "./LinkedWesl";
+import type { ExtendedGPUValidationError } from "./LinkedWesl.ts";
 
 /**
  * We want the WebGPU compilation errors to point at WESL code.

tools/packages/wesl/src/parse/WeslBaseGrammar.ts

@@ -1,5 +1,5 @@
 import { kind, or, withSepPlus } from "mini-parse";
-import type { WeslTokenKind } from "./WeslStream";
+import type { WeslTokenKind } from "./WeslStream.ts";
 
 export const word = kind<WeslTokenKind>("word");
 export const keyword = kind<WeslTokenKind>("keyword");

tools/packages/wesl/src/test/Tokenizer.test.ts

@@ -1,5 +1,5 @@
 import { expect, test } from "vitest";
-import { WeslStream, type WeslToken } from "../parse/WeslStream";
+import { WeslStream, type WeslToken } from "../parse/WeslStream.ts";
 
 test("tokenize empty string", () => {
   const tokenizer = new WeslStream("");

tools/packages/wesl/src/test/WeslDevice.test.ts

@@ -1,8 +1,7 @@
-import { setTimeout } from "node:timers";
 import { SrcMap } from "mini-parse";
 import { expect, test, vi } from "vitest";
-import { LinkedWesl } from "../LinkedWesl";
-import { makeWeslDevice } from "../WeslDevice";
+import { LinkedWesl } from "../LinkedWesl.ts";
+import { makeWeslDevice } from "../WeslDevice.ts";
 
 test("WeslDevice doesn't conflict with uncapturederror", async () => {
   const GPUDeviceMock = vi.fn(function (this: GPUDevice) {

tools/tsconfig.base.json

@@ -1,7 +1,8 @@
 {
   "compilerOptions": {
     "target": "ES2024", // we can expect a modern version with WebGPU (but we want stablility, so not "esnext")
-    "lib": ["ES2024"],
+    /* We're running in both in Node.js and browsers, but we have to pick one of them for type checking */
+    "lib": ["ES2024", "DOM"],
 
     "noEmit": true, // we don't transpile with tsgo, we just typecheck
 
@@ -23,8 +24,9 @@
     /* strictness in TypeScript */
     "strict": true,
     "noFallthroughCasesInSwitch": true,
-    "noUncheckedSideEffectImports": true
+    "noUncheckedSideEffectImports": true,
     // "noUncheckedIndexedAccess": true // maybe later, some lint to fix first
+    "types": []
   },
   "exclude": ["**/node_modules", "**/dist"]
 }

tools/tsconfig.node.json

@@ -1,8 +1,9 @@
 {
   "extends": "./tsconfig.base.json",
   "compilerOptions": {
-    "types": ["node", "@webgpu/types"],
-    "target": "ESNext", // we presume that dev machines are up to date
-    "lib": ["ESNext"]
-  }
+    "lib": ["ESNext", "DOM"],
+    "types": ["@types/node", "@webgpu/types"],
+    "target": "ESNext" // we presume that dev machines are up to date
+  },
+  "include": []
 }