Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCloseable Behavior Inconsistencies Across Dialog Classes #130

Open
jturfanbasis opened this issue Dec 16, 2024 · 1 comment
Open

setCloseable Behavior Inconsistencies Across Dialog Classes #130

jturfanbasis opened this issue Dec 16, 2024 · 1 comment
Assignees

Comments

@jturfanbasis
Copy link

The setCloseable(boolean closeable) feature of the Dialog component exhibits inconsistent behavior across various classes in the repository. Depending on the class, the dialog closure triggered by either the ESC key or clicking outside the dialog does not work as expected.

image

Expected Behavior
For all classes implementing the setCloseable(true) feature, the dialog should close when:

  1. The ESC key is pressed.
  2. The user clicks outside the dialog.

Actual Behavior
Some dialogs fail to close with the ESC key or when clicking outside, even with setCloseable(true) configured.

@hyyan
Copy link
Member

hyyan commented Jan 8, 2025

@EHandtkeBasis, ensure that all dialog are reopened again when closed in all demos, unless the demo has a specific open dialog button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants