Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix explosions for shadowrealm tests in idlharness #6974

Open
jcscottiii opened this issue Dec 3, 2024 · 0 comments
Open

Comments

@jcscottiii
Copy link
Collaborator

jcscottiii commented Dec 3, 2024

Background

This manifest PR failed to merge. It was because of this WPT PR. In that PR, it removed explicit shadowrealm test files and instead added metadata to the neighboring idlharness.any.js. However, when we go to manually fix the test reference like usual (example), it still fails saying that it can't find the test file.

From @KyleJu 's comment:

I believe that web-platform-tests/wpt#49342 introduced a new type of scope keywords, which is not the list of filename suffixes that wpt.fyi generates. It broke the manifest file generation.

In the meantime, we will remove the tests and keep this issue to investigate.

Definition of done

  • Implement a solution that catches this case
  • Revert this commit and add the tests back in with the corrected references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant