fix(diagnostic): fix excessively large width causing format_args panics (#10109)

* fix(diagnostic): fix excessively large width causing `format_args` panics

* test: update snapshot

Author: h-a-n-a

Cargo.lock

@@ -12,7 +12,7 @@ anyhow             = { workspace = true, features = ["backtrace"] }
 cow-utils          = { workspace = true }
 derive_more        = { workspace = true, features = ["debug"] }
 futures            = { workspace = true }
-miette             = { version = "7.2.0", features = ["fancy"] }
+miette             = { version = "7.5.0", features = ["fancy"] }
 once_cell          = { workspace = true }
 owo-colors         = "4.0.0"
 rspack_cacheable   = { workspace = true }

crates/rspack_error/Cargo.toml

@@ -696,6 +696,12 @@ impl GraphicalReportHandler {
         let num_left = vbar_offset - start;
         let num_right = end - vbar_offset - 1;
         if start < end {
+          let width = start.saturating_sub(highest);
+          // CHANGE:
+          // Rust PR https://github.com/rust-lang/rust/issues/99012 limited format string width and precision to 16 bits, causing panics when dynamic padding exceeds `u16::MAX`.
+          // This fixes exessively large width that exceeds `u16::MAX` by directly printing exceeded width.
+          let pre_width = width.saturating_sub(u16::MAX as usize);
+          underlines.push_str(&format!("{:width$}", "", width = pre_width));
           underlines.push_str(
             &format!(
               "{:width$}{}{}{}",
@@ -709,7 +715,7 @@ impl GraphicalReportHandler {
                 chars.underline
               },
               chars.underline.to_string().repeat(num_right),
-              width = start.saturating_sub(highest),
+              width = width.min(u16::MAX as usize),
             )
             .style(hl.style)
             .to_string(),

crates/rspack_error/src/graphical.rs

@@ -64,8 +64,7 @@ Rspack compiled successfully (27eddb11e03f28d2)
 exports[`new code splitting stats output new code splitting stats output/builtin-swc-loader-parse-error should print correct stats for: NewCodeSplittingStatsOutput 1`] = `
 ERROR in ./index.ts
   × Module build failed:
-  ├─▶   ×
-  │     │   x Expected '{', got 'error'
+  ├─▶   ×   x Expected '{', got 'error'
   │     │    ,-[<TEST_TOOLS_ROOT>/tests/statsOutputCases/builtin-swc-loader-parse-error/index.ts<LINE_COL>]
   │     │  1 | export error;
   │     │    :        ^^^^^

packages/rspack-test-tools/tests/__snapshots__/NewCodeSplitting-stats-output.test.js.snap

@@ -64,8 +64,7 @@ Rspack compiled successfully (27eddb11e03f28d2)
 exports[`statsOutput statsOutput/builtin-swc-loader-parse-error should print correct stats for 1`] = `
 ERROR in ./index.ts
   × Module build failed:
-  ├─▶   ×
-  │     │   x Expected '{', got 'error'
+  ├─▶   ×   x Expected '{', got 'error'
   │     │    ,-[<TEST_TOOLS_ROOT>/tests/statsOutputCases/builtin-swc-loader-parse-error/index.ts<LINE_COL>]
   │     │  1 | export error;
   │     │    :        ^^^^^

packages/rspack-test-tools/tests/__snapshots__/StatsOutput.test.js.snap

@@ -1,12 +1,10 @@
 ERROR in ./index.tsx
   × Module build failed:
-  ├─▶   ×
-  │     │   x Expected a semicolon
+  ├─▶   ×   x Expected a semicolon
   │     │    ,-[<TEST_TOOLS_ROOT>/tests/diagnosticsCases/builtins/recoverable_syntax_error/index.tsx<LINE_COL>]
   │     │  1 | let c = <test>() => {}</test>;
   │     │    :                       ^
   │     │    `----
-  │     │
   │     │   x Expression expected
   │     │    ,-[<TEST_TOOLS_ROOT>/tests/diagnosticsCases/builtins/recoverable_syntax_error/index.tsx<LINE_COL>]
   │     │  1 | let c = <test>() => {}</test>;