test: display error location in jsdom (#11937)

* test: display error location in jsdom

* test: display error location in jsdom

* test: display error location in jsdom

Author: LingyuCoder

packages/rspack-test-tools/src/helper/legacy/asModule.js

@@ -16,17 +16,15 @@ module.exports = async (something, context, unlinked) => {
 	const code = [...new Set(["default", ...Object.keys(something)])]
 		.map(
 			name =>
-				`const _${name} = ${SYNTHETIC_MODULES_STORE}[${i}]${
-					name === "default" ? "" : `[${JSON.stringify(name)}]`
+				`const _${name} = ${SYNTHETIC_MODULES_STORE}[${i}]${name === "default" ? "" : `[${JSON.stringify(name)}]`
 				}; export { _${name} as ${name}};`
 		)
 		.join("\n");
 	const m = new vm.SourceTextModule(code, {
 		context
 	});
 	if (unlinked) return m;
-	await m.link(() => {});
-	if (m.instantiate) m.instantiate();
+	await m.link(() => { });
 	await m.evaluate();
 	return m;
 };

packages/rspack-test-tools/src/runner/node/index.ts

@@ -340,7 +340,7 @@ export class NodeRunner<T extends ECompilerType = ECompilerType.Rspack>
 			this.requireCache[file.path] = m;
 
 			if (!this._options.runInNewContext) {
-				file.content = `Object.assign(global, _globalAssign);\n ${file.content}`;
+				file.content = `Object.assign(global, _globalAssign);${file.content}`;
 			}
 
 			const currentModuleScope = this.createModuleScope(
@@ -468,7 +468,6 @@ export class NodeRunner<T extends ECompilerType = ECompilerType.Rspack>
 					});
 				}
 
-				if ((esm as any).instantiate) (esm as any).instantiate();
 				await esm.evaluate();
 				if (context.esmMode === EEsmMode.Evaluated) {
 					return esm;

packages/rspack-test-tools/src/runner/web/index.ts

@@ -1,13 +1,15 @@
 import fs from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
+import { Script } from "node:vm";
 import { JSDOM, ResourceLoader, VirtualConsole } from "jsdom";
 import { escapeSep } from "../../helper";
 import EventSource from "../../helper/legacy/EventSourceForNode";
 import urlToRelativePath from "../../helper/legacy/urlToRelativePath";
 import type { ECompilerType, TRunnerFile, TRunnerRequirer } from "../../type";
 import { type INodeRunnerOptions, NodeRunner } from "../node";
 
+const EVAL_LOCATION_REGEX = /<anonymous>:(\d+)/;
 export interface IWebRunnerOptions<
 	T extends ECompilerType = ECompilerType.Rspack
 > extends INodeRunnerOptions<T> {
@@ -236,6 +238,41 @@ export class WebRunner<
 			}
 		}
 
+		const createLocatedError = (e: Error, file: TRunnerFile) => {
+			const match = (e.stack || e.message).match(EVAL_LOCATION_REGEX);
+			if (match) {
+				const [, line] = match;
+				const realLine = Number(line) - 34;
+				const codeLines = file.content.split("\n");
+				const lineContents = [
+					...codeLines
+						.slice(Math.max(0, realLine - 3), Math.max(0, realLine - 1))
+						.map(line => `│  ${line}`),
+					`│> ${codeLines[realLine - 1]}`,
+					...codeLines.slice(realLine, realLine + 2).map(line => `│  ${line}`)
+				];
+				const message = `Error in JSDOM when running file '${file.path}' at line ${realLine}: ${e.message}\n${lineContents.join("\n")}`;
+				const finalError = new Error(message);
+				finalError.stack = undefined;
+				return finalError;
+			} else {
+				return e;
+			}
+		};
+		const originIt = currentModuleScope.it;
+		currentModuleScope.it = (
+			description: string,
+			fn: () => Promise<void> | void
+		) => {
+			originIt(description, async () => {
+				try {
+					await fn();
+				} catch (err) {
+					throw createLocatedError(err as Error, file);
+				}
+			});
+		};
+
 		const scopeKey = escapeSep(file!.path);
 		const args = Object.keys(currentModuleScope).filter(
 			arg => !["window", "self", "globalThis", "console"].includes(arg)
@@ -245,10 +282,12 @@ export class WebRunner<
 			.join(", ");
 		this.dom.window[scopeKey] = currentModuleScope;
 		this.dom.window["__GLOBAL_SHARED__"] = this.globalContext;
+		this.dom.window["__FILE__"] = file;
+		this.dom.window["__CREATE_LOCATED_ERROR__"] = createLocatedError;
+
 		return [
 			m,
-			`
-			// hijack document.currentScript for auto public path
+			`// hijack document.currentScript for auto public path
 			var $$g$$ = new Proxy(window, {
 				get(target, prop, receiver) {
 					if (prop === "document") {
@@ -281,9 +320,12 @@ export class WebRunner<
 				}
 			});
 			(function(window, self, globalThis, console, ${args.join(", ")}) {
-				${file.content}
-			})($$g$$, $$self$$, $$g$$, window["console"], ${argValues});
-		`
+				try {
+				  ${file.content}
+				} catch (err) {
+					throw __CREATE_LOCATED_ERROR__(err, __FILE__);
+				}
+			})($$g$$, $$self$$, $$g$$, window["console"], ${argValues});`
 		];
 	}
 
@@ -301,7 +343,11 @@ export class WebRunner<
 			const [m, code] = this.getModuleContent(file);
 
 			this.preExecute(code, file);
-			this.dom.window.eval(code);
+
+			const script = new Script(code);
+			const vmContext = this.dom.getInternalVMContext();
+			script.runInContext(vmContext);
+
 			this.postExecute(m, file);
 
 			this.requireCache[file.path] = m;

packages/rspack-test-tools/src/test/creator.ts

@@ -310,10 +310,11 @@ export class BasicCaseCreator<T extends ECompilerType> {
 					}
 					try {
 						await runFn(fn);
-					} catch (e) {
-						throw new Error(
-							`Error: ${description} failed\n${(e as Error).stack}`
-						);
+					} catch (err) {
+						const e = err as Error;
+						const message = `Error: ${description} failed:\n${e.message}`;
+						e.message = message;
+						throw e;
 					}
 					for (const after of afterTasks) {
 						await runFn(after);