feat: solve memory leaks

Author: keepview

packages/server/core/src/serverBase.ts

@@ -180,6 +180,12 @@ export class ServerBase<E extends Env = any> {
   get onError() {
     return this.app.onError.bind(this.app);
   }
+
+  close() {
+    this.serverContext = null;
+    this.plugins = [];
+    (this.app as Hono<E> | null) = null;
+  }
 }
 
 export function createServerBase<E extends Env>(options: ServerBaseOptions) {

packages/server/server/src/createDevServer.ts

@@ -8,9 +8,11 @@ import { logger } from '@modern-js/utils';
 import { devPlugin, manager } from './dev';
 import { getDevAssetPrefix, getDevOptions } from './helpers';
 import { ResourceType } from './helpers/utils';
-import serverHmrPlugin from './plugins/serverHmr';
+import serverHmrPlugin from './plugins/serverReload';
 import type { ApplyPlugins, ModernDevServerOptions } from './types';
 
+export let serverReload: (() => Promise<void>) | null = null;
+
 async function createServerOptions(
   options: ModernDevServerOptions,
   serverConfigPath: string,
@@ -44,8 +46,8 @@ export async function createDevServer(
     distDir,
   );
 
-  const server = createServerBase(prodServerOptions);
-  let currentServer = server;
+  let currentServer = createServerBase(prodServerOptions);
+
   let isReloading = false;
 
   const devHttpsOption = typeof dev === 'object' && dev.https;
@@ -75,8 +77,10 @@ export async function createDevServer(
     if (isReloading) {
       return;
     }
+    isReloading = true;
+
     try {
-      isReloading = true;
+      await currentServer.close();
 
       const updatedProdServerOptions = await createServerOptions(
         options,
@@ -88,25 +92,30 @@ export async function createDevServer(
       await manager.close(ResourceType.Watcher);
 
       newServer.addPlugins([
-        serverHmrPlugin(reload),
-        devPlugin({
-          ...options,
-        }),
+        serverHmrPlugin(),
+        devPlugin(
+          {
+            ...options,
+            builderDevServer: undefined,
+          },
+          true,
+        ),
       ]);
-      await applyPlugins(newServer, updatedProdServerOptions, nodeServer);
+      await applyPlugins(newServer, updatedProdServerOptions);
       await newServer.init();
 
       currentServer = newServer;
+
       logger.info(`Custom Web Server HMR succeeded`);
     } catch (e) {
       logger.error('[Custom Web Server HMR failed]:', e);
     } finally {
       isReloading = false;
     }
   };
-
-  server.addPlugins([
-    serverHmrPlugin(reload),
+  serverReload = reload;
+  currentServer.addPlugins([
+    serverHmrPlugin(),
     devPlugin({
       ...options,
       builderDevServer,
@@ -119,9 +128,9 @@ export async function createDevServer(
     prodServerOptions.config.output.assetPrefix = assetPrefix;
   }
 
-  await applyPlugins(server, prodServerOptions, nodeServer);
+  await applyPlugins(currentServer, prodServerOptions, nodeServer);
 
-  await server.init();
+  await currentServer.init();
 
   const afterListen = async () => {
     await builderDevServer?.afterListen();

packages/server/server/src/dev.ts

@@ -21,7 +21,10 @@ export type DevPluginOptions = ModernDevServerOptions<ServerBaseOptions> & {
 
 export const manager = new ResourceManager();
 
-export const devPlugin = (options: DevPluginOptions): ServerPlugin => ({
+export const devPlugin = (
+  options: DevPluginOptions,
+  isReload = false,
+): ServerPlugin => ({
   name: '@modern-js/plugin-dev',
 
   setup(api) {
@@ -56,11 +59,12 @@ export const devPlugin = (options: DevPluginOptions): ServerPlugin => ({
       // TODO: remove any
       const hooks = (api as any).getHooks();
 
-      builder?.onDevCompileDone(({ stats }) => {
-        if (stats.toJson({ all: false }).name !== 'server') {
-          onRepack(distDirectory!, hooks);
-        }
-      });
+      !isReload &&
+        builder?.onDevCompileDone(({ stats }) => {
+          if (stats.toJson({ all: false }).name !== 'server') {
+            onRepack(distDirectory!, hooks);
+          }
+        });
 
       const { watchOptions } = config.server;
       const watcher = startWatcher({

packages/server/server/src/plugins/serverHmr.ts renamed to packages/server/server/src/plugins/serverReload.ts

@@ -1,8 +1,10 @@
 import path from 'path';
 import type { ServerPlugin } from '@modern-js/server-core';
 
-export default (reload: () => Promise<void>): ServerPlugin => ({
-  name: '@modern-js/server-hmr-plugin',
+import { serverReload } from '../createDevServer';
+
+export default (): ServerPlugin => ({
+  name: '@modern-js/server-reload-plugin',
   setup: api => {
     api.onReset(async ({ event }) => {
       if (event.type === 'file-change') {
@@ -14,7 +16,7 @@ export default (reload: () => Promise<void>): ServerPlugin => ({
             filename.startsWith(serverPath) && !filename.startsWith(indexPath),
         );
         if (isServerFileChanged) {
-          await reload();
+          await serverReload?.();
         }
       }
     });