Skip to content

Conversation

@madoxas
Copy link

@madoxas madoxas commented Dec 2, 2024

Fixes ring-clojure/ring#517

Note: This is a breaking change!

I'm open for suggestions, if there's a need to support both javax and jakarta servlets in the code.

@weavejester
Copy link
Owner

Thanks for the PR. This should be okay, as the javax servlets are deprecated in pretty much everything, and Lein-Ring is not 1.0 so there's no guarantee of backward compatibility. That said, if someone complains we can always put an option in to switch from one to the other.

Have you tested this change? Does it produce a war file that runs under a servlet container?

Also, can you change the commit message to:

Replace javax servlet classes with Jakarta servlet

This will make it consistent with the other commits in the repository.

@madoxas
Copy link
Author

madoxas commented Dec 2, 2024

Also, can you change the commit message

Done.

Have you tested this change? Does it produce a war file that runs under a servlet container?

Yes, tested on Tomcat 11. Works as expected.

@madoxas madoxas changed the title feat: replace javax servlet with jakarta Replace javax servlet classes with Jakarta servlet Dec 2, 2024
@jeffdik
Copy link

jeffdik commented Feb 11, 2025

Thank you for your work on this. Any idea of when this will be released?

@waynedyck
Copy link

I tested this pull request today with a project and it fixed the error I was seeing previously when running lein ring uberwar

Previously bumping from ring "1.10.0" to any later version produced the following error:

Syntax error macroexpanding at (jetty.clj:1:1).
Execution error (FileNotFoundException) at ring.adapter.jetty/loading (jetty.clj:1).
Could not locate ring/websocket__init.class, ring/websocket.clj or ring/websocket.cljc on classpath.

After using the pull request locally, lein ring uberwar correctly generated the .WAR file without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build uberwar with jakarta servlet

4 participants