Polish workbench viewer demo experience#2
Open
wdwd720 wants to merge 2 commits into
Open
Conversation
…S, robotics, API, SOFA adapter, artifact bundle, dataset export, eval runner, all tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it refactors the workbench
Viewerinto many new components, adds EXR/GLB loading and query-param/clipboard interactions that could affect rendering performance or stability, but it’s frontend-only with fallback behavior when assets fail.Overview
Polishes the workbench viewer into an asset-backed demo mode: optional HDRI (EXR) environment/background and an optional static “hero robot” GLB can be toggled without changing backend-driven geometry, with explicit fallback when assets are missing or fail.
Adds a new in-view control rail and status overlay to switch camera presets, reset the view, toggle presentation/compact/debug modes, and copy a shareable URL; these controls are synchronized to query parameters (
hdri,heroRobot,cameraPreset,presentation,assetDebug, plus deferredtable).Refactors
Viewer.tsxto use new modular components, updates renderer settings (shadows, tone mapping, fog), and documents the demo asset paths and URL controls indocs/workbench.md.Reviewed by Cursor Bugbot for commit d95b446. Bugbot is set up for automated code reviews on this repo. Configure here.