Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MKF buffer or use a priority queue #54

Open
SabaAflaki opened this issue Jun 24, 2016 · 1 comment
Open

Remove MKF buffer or use a priority queue #54

SabaAflaki opened this issue Jun 24, 2016 · 1 comment

Comments

@SabaAflaki
Copy link

SabaAflaki commented Jun 24, 2016

./Tracker.h:638: std::vector< MultiKeyFrame* > mvKeyFrameBuffer; ///< vector that holds MKF pointers

We can either remove the buffer or use a priority queue (That keeps the N latest MKFs) instead.

@SabaAflaki
Copy link
Author

SabaAflaki commented Jun 30, 2016

Priority queue will be helpful only in the current version where we can infinitely add MKFs (no buffer size restrictions). With a limited buffer size to keep the last N MKFs, after the priority queue is full, every time we want to insert an MKF we have to remove the oldest MKF and insert the new one which is O(logn) as opposed to O(1) in a circular buffer. So, I'll go with Arun's opinion for a limited buffer size and a circular buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant