Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Rule names to always be URLs #7

Open
leostera opened this issue Mar 11, 2023 · 0 comments
Open

Refactor Rule names to always be URLs #7

leostera opened this issue Mar 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@leostera
Copy link
Member

At the moment we have a few places where Rule names are being handled as bare strings, which can be the short-name of the rule (like mix_release) or the full name (like https://rules.warp.build/rules/mix_release.js).

I think we should just use URLs for this and normalize as soon as we get a string from a Tricorder.
@leostera leostera added the enhancement New feature or request label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leostera