Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor .gitignore files #12

Open
leostera opened this issue Mar 17, 2023 · 1 comment
Open

Honor .gitignore files #12

leostera opened this issue Mar 17, 2023 · 1 comment
Assignees
@Enkronan
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@leostera
Copy link
Member

Right now some of the glob expansion that Warp does, doesn't always follow the ignored files, so sometimes we pick up files that don't end up as part of the official sources.

This happened while pairing with @diogomqbm, and we found out that there was a folder in the BEAM tricorder that had just been ignored, but locally it was being picked up by warp and building.

Edge case, but good to consider this more generally.
@leostera leostera added enhancement New feature or request good first issue Good for newcomers labels Mar 17, 2023
@leostera
Copy link
Member Author

We can use the ignore crate.

@Enkronan Enkronan self-assigned this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enkronan Enkronan

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

12-honor-gitignore-files warp-build/warp
2 participants
@leostera @Enkronan