fix null default values

Author: benbroadaway

github-app-installation/src/main/java/com/walmartlabs/concord/github/appinstallation/cfg/GitHubAppInstallationConfig.java

@@ -119,7 +119,7 @@ static OauthConfig from(com.typesafe.config.Config cfg) {
             return new OauthConfig(
                     getStringOrDefault(cfg, "id", () -> "github-oauth-token"),
                     cfg.getString("urlPattern"),
-                    getStringOrDefault(cfg, "username", null),
+                    getStringOrDefault(cfg, "username", () -> null),
                     cfg.getString("token")
             );
         }
@@ -139,11 +139,11 @@ record AppInstallationConfig(String id, String urlPattern, String username, Stri
 
         static AppInstallationConfig from(com.typesafe.config.Config cfg) {
 
-            var username = Optional.ofNullable(getStringOrDefault(cfg, "apiUrl", null))
+            var username = Optional.ofNullable(getStringOrDefault(cfg, "username", () -> null))
                     .filter(s -> !s.isBlank())
                     .orElse("x-access-token");
 
-            var apiUrl = Optional.ofNullable(getStringOrDefault(cfg, "apiUrl", null))
+            var apiUrl = Optional.ofNullable(getStringOrDefault(cfg, "apiUrl", () -> null))
                     .filter(s -> !s.isBlank())
                     .orElse("https://api.github.com");
 

server/dist/src/main/resources/concord-server.conf

@@ -527,6 +527,7 @@ concord-server {
             # Importantly, urlPattern must include a regex capture group named 'baseUrl'.
             # This is necessary to detect where the owner/repo values begin in the path.
             # {
+            #     id = "my-gh-app",  # identifier for the config, e.g. for metrics
             #     type = "GITHUB_APP_INSTALLATION",
             #     urlPattern = "(?<baseUrl>github.com)",  # regex
             #     username = "...",  # optional, defaults to "x-access-token"
@@ -537,10 +538,12 @@ concord-server {
             # or static oauth config. Not exactly a "GitHub App", but can do some
             # API interactions and cloning. Actual app installation is preferred.
             # {
+            #     id = "my-static-token",  # identifier for the config, e.g. for metrics
             #     type = "OAUTH_TOKEN",
             #     token = "...",
             #     username = "...",  # optional, usually not necessary
             #     urlPattern = "..." # regex to match against git server's hostname + port + path
+            #     apiUrl = "https://api.github.com", # github API url, usually *not* the same as the repo url host/path
             # }
             auth = []