Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writeMultipleProperties() method misses op writeallproperties #362

Open
danielpeintner opened this issue Jan 10, 2022 · 3 comments
Open
Labels
API-improvement Suggestions for changing the API for next iteration Planned or postponed topics for the future priority: high Issues that will be tackled in 2024 wait-for-td

Comments

@danielpeintner
Copy link
Contributor

The writeMultipleProperties() method states in Step 3

If option's formIndex is defined, let form be the Form associated with formIndex in [[td]]'s forms array, otherwise let form be a Form in [[td]]'s forms array whose op is writemultipleproperties, selected by the implementation.

Should we also op writeallproperties ?

relates to #219

@zolkis
Copy link
Contributor

zolkis commented Jan 10, 2022

The TD spec should specify better the writeallproperties op, including error cases.

IMHO from a script's point of view, writeProperties() should be able to cover both writeMultipleProperties and writeAllProperties.

The only difference between them could be that writeAllProperties would replace all properties at the target, i.e. remove the properties not specified by writeAllProperties. However, such behaviour is not specified in the TD spec, therefore at the moment writeAll and writeMultiple are the same, from Scripting side.

Please suggest algorithms for both writeMultipleProperties() and writeAllProperties() and point out how would they differ.

@danielpeintner
Copy link
Contributor Author

Let's wait what we can achieve in w3c/wot-thing-description#1349

@relu91 relu91 added the enhancement Thoughts and ideas about possible improvements label Dec 11, 2023
@relu91 relu91 added for next iteration Planned or postponed topics for the future API-improvement Suggestions for changing the API priority: high Issues that will be tackled in 2024 wait-for-td and removed enhancement Thoughts and ideas about possible improvements labels Jan 22, 2024
@danielpeintner
Copy link
Contributor Author

I added the label "Needed by other TF" to w3c/wot-thing-description#1349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-improvement Suggestions for changing the API for next iteration Planned or postponed topics for the future priority: high Issues that will be tackled in 2024 wait-for-td
Projects
None yet
Development

No branches or pull requests

3 participants