Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling gather() multiple times #7

Open
steveanton opened this issue Jun 12, 2018 · 1 comment
Open

Calling gather() multiple times #7

steveanton opened this issue Jun 12, 2018 · 1 comment
Assignees
Labels
PR needed A pull request is needed.

Comments

@steveanton
Copy link
Collaborator

What happens if gather() is called multiple times?

Peter suggested adding something like: "if not in the gathering state of complete, runs draft-ietf-ice-rfc5245bis section 5.1.1.1 again and trickles them as they come."

@aboba
Copy link
Contributor

aboba commented Jun 12, 2018

In general this seems reasonable, though in some situations throwing an exception might be appropriate:

  • If RTCIceTransportPolicy is changed (from less restrictive to more restrictive, so candidates already
    trickled are now excluded)
  • If RTCIceServers is changed (so that a relay candidate already trickled may not be valid anymore).

This does leave open the question of what happens if the gathering state is "complete". Would this imply an ICE restart?

@aboba aboba added the question label Jun 12, 2018
@aboba aboba added PR needed A pull request is needed. and removed question labels Aug 2, 2018
@aboba aboba assigned alvestrand and unassigned steveanton Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR needed A pull request is needed.
Projects
None yet
Development

No branches or pull requests

3 participants