Rename onerror to onicecandidateerror?
#47
Comments
tidoust
added a commit
to w3c/strudy
that referenced
this issue
Sep 11, 2024
This duplicates the calls to Strudy in the analysis job: first pass analyzes the raw crawl results, second pass runs further analyses (not the same ones!) on the curated crawl results. IDL analyses are now done as part of the second pass. The rationale is that some IDL anomalies may be indirectly triggered by another IDL hiccup that we already identified and reported while doing data curation in Webref. This makes it at least theoretically possible to end up in a situation where we detect an anomaly twice (from two different angles). It seems better to run further IDL analyses on the curated branch instead. This is particularly needed for the new `noEvent` anomaly, which would otherwise report problems that our events patching already takes care of. The `noEvent` anomaly will create two issues next time the job runs: - one for `HTMLBodyElement.onorientationchange`, already covered in the spec: https://compat.spec.whatwg.org/#windoworientation-interface - one for `RTCIceTransport.onerror`, already tracked in: w3c/webrtc-ice#47
dontcallmedom
pushed a commit
to w3c/strudy
that referenced
this issue
Sep 11, 2024
This duplicates the calls to Strudy in the analysis job: first pass analyzes the raw crawl results, second pass runs further analyses (not the same ones!) on the curated crawl results. IDL analyses are now done as part of the second pass. The rationale is that some IDL anomalies may be indirectly triggered by another IDL hiccup that we already identified and reported while doing data curation in Webref. This makes it at least theoretically possible to end up in a situation where we detect an anomaly twice (from two different angles). It seems better to run further IDL analyses on the curated branch instead. This is particularly needed for the new `noEvent` anomaly, which would otherwise report problems that our events patching already takes care of. The `noEvent` anomaly will create two issues next time the job runs: - one for `HTMLBodyElement.onorientationchange`, already covered in the spec: https://compat.spec.whatwg.org/#windoworientation-interface - one for `RTCIceTransport.onerror`, already tracked in: w3c/webrtc-ice#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I bumped into the definition of
RTCIceTransport.onerrorwhile analyzing event handler attributes and events that specs define (context in w3c/webref#1216).The Web Platform Design Principles (implicitly) recommend to name event handler attributes after the event type. The HTML spec also has:
The
RTCIceTransport.onerrorattribute seems to be the only event handler attribute throughout the web platform whose name does not follow that convention. I'm wondering whether the mismatch was intended and whether the attribute could be renamed toonicecandidateerror.The text was updated successfully, but these errors were encountered: