Allow web applications to select SFrame cipher suite as a parameter provided to SFrameTransform constructor. #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovided to SFrameTransform constructor. Also updates the link to the SFrame specification now that it is a RFC.
youennf
force-pushed
the
introducesframetransform-ciphersuite
branch
from
0a6d9c2 to
71acd32
Compare
alvestrand
reviewed
Jun 5, 2025
| "AES_128_CTR_HMAC_SHA256_64", | ||
| "AES_128_CTR_HMAC_SHA256_32", | ||
| "AES_128_GCM_SHA256_128", | ||
| "AES_256_GCM_SHA512_128" |
There was a problem hiding this comment.
Why these particular ciphersuites? If they're defined by 9605 section 4.5 and no others can be used, we should be sure to say so.
Should there be an MTI ciphersuite?
There was a problem hiding this comment.
These cipher suites are indeed the ones defined by RFC 9605.
No other can be used given we use an enumeration here.
I would think that all cipher suites are MTI if a UA implements SFrameTransform.
|
I wonder whether we want a specific error type for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256.
Also updates the link to the SFrame specification now that it is a RFC.
Preview | Diff