Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add isSyncable property to BookmarkTreeNode #733

Open
oliverdunk opened this issue Dec 5, 2024 · 2 comments
Open

Proposal: Add isSyncable property to BookmarkTreeNode #733

oliverdunk opened this issue Dec 5, 2024 · 2 comments
Labels
neutral: firefox Not opposed or supportive from Firefox neutral: safari Not opposed or supportive from Safari supportive: chrome Supportive from Chrome

Comments

@oliverdunk
Copy link
Member

oliverdunk commented Dec 5, 2024

Proposal

Add a new isSyncable property to BookmarkTreeNode. This will be set to true if the user has sync enabled and this is a node which will be synced.

Motivation

An existing problem is that developers may wish to indicate to a user if bookmarks saved in a given folder will be uploaded to a user's account.

As part of changes to the sync model in Chrome, we are planning to change the bookmark tree in a way that may introduce a mix of syncing and non-syncing folders to the tree.

Before we do this, we'd like to make it easier for developers to distinguish them.

@github-actions github-actions bot added needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time needs-triage: safari Safari needs to assess this issue for the first time labels Dec 5, 2024
@oliverdunk oliverdunk added supportive: chrome Supportive from Chrome and removed needs-triage: chrome Chrome needs to assess this issue for the first time labels Dec 5, 2024
@xeenon xeenon added neutral: safari Not opposed or supportive from Safari and removed needs-triage: safari Safari needs to assess this issue for the first time labels Dec 5, 2024
@Rob--W Rob--W added neutral: firefox Not opposed or supportive from Firefox and removed needs-triage: firefox Firefox needs to assess this issue for the first time labels Dec 5, 2024
@oliverdunk
Copy link
Member Author

We've started work on a CL for this (https://chromium-review.googlesource.com/c/chromium/src/+/6087835) and are discussing naming before finishing implementation.

We came up with inAccount which we quite like as it matches our UI and is roughly how we would want an extension to communicate this to users. It also seems consistent with the user-facing terminology in other browsers. We're also trying to move away from "sync" as a user facing term.

That said, we still use sync elsewhere in the extension APIs, so while we're slightly leaning towards inAccount would be comfortable with terminology based on that as well.

Any thoughts @Rob--W / @xeenon?

@Rob--W
Copy link
Member

Rob--W commented Dec 24, 2024

Any thoughts @Rob--W / @xeenon?

Relevant part of the meeting notes:

[Issue 733](https://github.com/w3c/webextensions/issues/733): Proposal: Add `isSyncable` property to BookmarkTreeNode
* [oliver] This issue was about indicating if a folder is synced. The name we're considering is `inAccount`. Feedback welcome. For context, we're trying to avoid using “sync” in user facing strings. Sync is well used in existing APIs, so there's a consistency argument there.
* [timothy] Prefer sync over inAccount, being generic eases adoption by other browsers.
* [rob] I'm not immediately sold on the account naming. In other APIs we use account and it's not clear what that means. Does the meaning of “sync” match what's used in storage.sync?
* [oliver] I think it largely matches.
* [rob] In that case I'm in favor of `isSyncable`. Other names are still welcome.
* [oliver] In `storage.sync`, extensions can add entries even without being logged in. In this case, it only appears when logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neutral: firefox Not opposed or supportive from Firefox neutral: safari Not opposed or supportive from Safari supportive: chrome Supportive from Chrome
Projects
None yet
Development

No branches or pull requests

3 participants