Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.2.0 mailto error — resource not found #1595

Closed
skwps opened this issue Jan 3, 2025 · 10 comments · Fixed by #1597
Closed

Release v5.2.0 mailto error — resource not found #1595

skwps opened this issue Jan 3, 2025 · 10 comments · Fixed by #1597
Assignees
Labels
priority: critical To be processed and published ASAP status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Milestone

Comments

@skwps
Copy link

skwps commented Jan 3, 2025

Epubcheck 5.2 is giving an error for an email link. The same EPUB shows no error in epubcheck 5.1.

ERROR(RSC-007): Referenced resource "mailto:[address]@[school].edu" could not be found in the EPUB.

Is there another step needed now to properly include an email link?

@rdeltour
Copy link
Member

rdeltour commented Jan 3, 2025

Thanks for the report!
Sounds like a regression bug, possibly introduced by #1582.

I’ll try to reproduce and fix in the next maintenance release.

@rdeltour rdeltour self-assigned this Jan 3, 2025
@rdeltour rdeltour added priority: high To be processed and published in the next release type: false-positive This issue is about valid content being incorrectly rejected status: needs test case A reproducible test case is needed to move the issue forward labels Jan 3, 2025
@rdeltour rdeltour added this to the Next maintenance release milestone Jan 3, 2025
@wareid
Copy link

wareid commented Jan 8, 2025

If it's helpful at all, I just came across this bug as well in multiple EPUB files while running my standard regression test for Kobo EPUBCheck integration. This causes EPUBs that previously validated with no errors in versions 4.2.6, 5.0.1, and 5.1.0 to throw validation errors.

@Changilainen
Copy link

I was about to create a new issue of this too. I get the same error with the version 5.2.0 but not with version 5.1.0. Hope it will be fixed asap before more and more people start to use the 5.2.0 version.

@prithiviclteam
Copy link

Dear @rdeltour,

We have encountered the same issue with mailto: links in Epubcheck 5.2. Thank you for acknowledging the problem and your efforts to address it in the next maintenance release.

Could you kindly share if there is an estimated timeline for the release? This information will help us plan accordingly on our end.

Looking forward to your response.

Best regards,
Prithiviraj M

@PurushM
Copy link

PurushM commented Jan 10, 2025

We have encountered the same issue with mailto: links in Epubcheck 5.2. Thank you for acknowledging the problem and your efforts to address it in the next maintenance release.

The "[email protected]" links, but I know for a fact that "mailto:[email protected]" is not a valid email link.

Please check and update

Thanks,
Purushothaman M

@rdeltour
Copy link
Member

Thanks everyone for confirming the bug. I am able to reproduce it myself and will work on a fix ASAP.

As for an estimated timeline, I can publish a patch release (v5.2.1) as soon as the bug is fixed.

This is quite a serious bug (false positive) which is likely to impact a significant number of publications, so I believe it is worth releasing a patch release sooner rather than wait for the next regular maintenance release.

@wareid

I just came across this bug as well in multiple EPUB files while running my standard regression test for Kobo EPUBCheck integration.

have you noticed any other issues in Kobo's regression tests? I'm trying to estimate if I can publish a patch ASAP or wait a little in case other regression bugs are detected.

@rdeltour rdeltour added status: has PR The issue is being processed in a pull request priority: critical To be processed and published ASAP and removed priority: high To be processed and published in the next release status: needs test case A reproducible test case is needed to move the issue forward labels Jan 10, 2025
@wareid
Copy link

wareid commented Jan 10, 2025

I just came across this bug as well in multiple EPUB files while running my standard regression test for Kobo EPUBCheck integration.

have you noticed any other issues in Kobo's regression tests? I'm trying to estimate if I can publish a patch ASAP or wait a little in case other regression bugs are detected.

I haven't seen any other issues in our regression tests, everything else is the same!

@rdeltour
Copy link
Member

rdeltour commented Jan 14, 2025

I just published v5.2.1, which fixes this regression bug.
Thanks again to everyone who reported the issue and tested for regression issues!

@PurushM
Copy link

PurushM commented Jan 15, 2025

Thanks for updated tool.

@prithiviclteam
Copy link

prithiviclteam commented Jan 16, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: critical To be processed and published ASAP status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants