Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a module-info.java Java module descriptor #1137

Open
rdeltour opened this issue May 1, 2020 · 2 comments
Open

Add a module-info.java Java module descriptor #1137

rdeltour opened this issue May 1, 2020 · 2 comments
Labels
priority: low To be processed when time allows status: needs contribution Needs contribution to move forward type: maintenance The issue is related to a meta task (build system, dependency update, etc)

Comments

@rdeltour
Copy link
Member

rdeltour commented May 1, 2020

Currently, EPUBCheck only provides the bare-minimum support for Java modules by declaring a Automatic-Module-Name entry to the jar manifest (see #1128).

It would be nice to also provide a proper module descriptor (module-info.java file). We already declare imports/exports for OSGi, so doing it for Java modules can hopefully be straightforward.

@rdeltour rdeltour added priority: low To be processed when time allows type: maintenance The issue is related to a meta task (build system, dependency update, etc) status: accepted Ready to be further processed labels May 1, 2020
@io7m
Copy link
Contributor

io7m commented May 1, 2020

The main problem you face in doing this is that you can't really modularize until your dependencies have also modularized. I wrote a plugin to track the modularization status of module dependencies. Unfortunately, the situation isn't great for epubcheck:

https://ataxia.io7m.com/2020/05/01/modulechaser/modules.xhtml

Note that the plugin treats all dependencies as being mandatory, and that's not necessarily the case. If I remember correctly, the imageio dependencies are only needed if you're actually doing processing/checking of images in epub.

@rdeltour
Copy link
Member Author

rdeltour commented May 1, 2020

Thanks for the info and analysis, very helpful. It looks like some of the core dependencies are not modularized…

@rdeltour rdeltour added status: needs contribution Needs contribution to move forward and removed status: accepted Ready to be further processed labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low To be processed when time allows status: needs contribution Needs contribution to move forward type: maintenance The issue is related to a meta task (build system, dependency update, etc)
Projects
None yet
Development

No branches or pull requests

2 participants