Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edupub implicit body test still needs aria-label #1109

Open
mattgarrish opened this issue Mar 12, 2020 · 0 comments
Open

edupub implicit body test still needs aria-label #1109

mattgarrish opened this issue Mar 12, 2020 · 0 comments
Assignees
Labels
spec: EDUPUB Impacting the support of the EDUPUB specification status: in discussion The issue is being discussed by the development team type: tests The issue is related to the test suite

Comments

@mattgarrish
Copy link
Member

There are two valid tests for the body element that differ only in that one has a heading and the other does not.

One is called an "explicit body" and the other an "implict body", but it doesn't make sense that both can be valid as the "implicit" one would still need an aria-label if it doesn't have an explicit heading.

I guess it validates because both tests only use sectioning content as children, so the "implicit body" test doesn't get flagged.

I think we can just drop this tests as there's already an invalid check for an implicit body without a heading and a valid test for a body that only contains sectioning elements.

@rdeltour rdeltour self-assigned this Mar 12, 2020
@rdeltour rdeltour added status: in discussion The issue is being discussed by the development team type: tests The issue is related to the test suite labels Mar 12, 2020
@rdeltour rdeltour added the spec: EDUPUB Impacting the support of the EDUPUB specification label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec: EDUPUB Impacting the support of the EDUPUB specification status: in discussion The issue is being discussed by the development team type: tests The issue is related to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants