Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUBCheck not reporting missing the # in refines="ID" in opf #1075

Open
garconvacher opened this issue Aug 30, 2019 · 3 comments
Open

EPUBCheck not reporting missing the # in refines="ID" in opf #1075

garconvacher opened this issue Aug 30, 2019 · 3 comments
Assignees
Labels
status: needs test case A reproducible test case is needed to move the issue forward type: unverified The issue couldn't be reproduced

Comments

@garconvacher
Copy link

garconvacher commented Aug 30, 2019

Hi,

I've got an EPUB (EPUBchecked 4.2.2) works fine in most of reading system but Lisa for iOS does not want to import it ("unknown file format").
I've found the problem in the opf with this markup:
<meta scheme="marc:relators" property="role" refines="ID">pbd</meta>

I remove all the # in refines="#id" in the opf, EPUBCheck only report an error: "Property 'collection-type' must refine a 'belongs-to-collection' property.'

@rdeltour
Copy link
Member

Thanks for the report, I’ll try to repro.

@rdeltour rdeltour self-assigned this Aug 30, 2019
@rdeltour rdeltour added status: accepted Ready to be further processed type: improvement The issue suggests an improvement of an existing feature labels Aug 30, 2019
@rdeltour rdeltour added this to the v5.0.0-rc milestone Dec 8, 2022
@rdeltour
Copy link
Member

rdeltour commented Dec 8, 2022

Tentatively adding this to v5.0.0-rc

@rdeltour
Copy link
Member

I could not reproduce the issue, with the following package document:

<?xml version="1.0" encoding="UTF-8"?>
<package xmlns="http://www.idpf.org/2007/opf" version="3.0" xml:lang="en" unique-identifier="id">
  <metadata xmlns:dc="http://purl.org/dc/elements/1.1/">
    <dc:title id="title">Minimal EPUB 3.0</dc:title>
    <dc:language>en</dc:language>
    <dc:identifier id="id">NOID</dc:identifier>
    <dc:creator id="creator">name</dc:creator>
    <meta property="dcterms:modified">2017-06-14T00:00:01Z</meta>
    <meta scheme="marc:relators" property="role" refines="creator">pbd</meta>
  </metadata>
  <manifest>
    <item id="content_001" href="content_001.xhtml" media-type="application/xhtml+xml"/>
    <item id="nav" href="nav.xhtml" media-type="application/xhtml+xml" properties="nav"/>
  </manifest>
  <spine>
    <itemref idref="content_001"/>
  </spine>
</package>

EPUBCheck did report RSC-005:

ERROR RSC-005: Error while parsing file: Property "role" must refine a "creator", "contributor", or "publisher" property.

Maybe it is no longer an issue?
I'm removing it from the v5.0.0 milestone, but keeping it open for confirmation.

@rdeltour rdeltour added type: unverified The issue couldn't be reproduced status: needs test case A reproducible test case is needed to move the issue forward and removed type: improvement The issue suggests an improvement of an existing feature status: accepted Ready to be further processed labels Dec 23, 2022
@rdeltour rdeltour removed this from the v5.0.0-rc milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test case A reproducible test case is needed to move the issue forward type: unverified The issue couldn't be reproduced
Projects
None yet
Development

No branches or pull requests

2 participants