Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting aria-checked on gridcells #1960

Open
smhigley opened this issue Jun 20, 2023 · 5 comments · May be fixed by #2390
Open

Consider supporting aria-checked on gridcells #1960

smhigley opened this issue Jun 20, 2023 · 5 comments · May be fixed by #2390
Milestone

Comments

@smhigley
Copy link
Contributor

smhigley commented Jun 20, 2023

Description of bug or feature request

We currently support aria-selected on gridcells, but aria-checked provides certain additional features that seem worthwhile to be able to use in a grid:

  • mixed-state selection
  • multiple selection, where checked/unchecked state is more consistently exposed and more user-friendly than selected/unselected state

A specific use case where this came up was in a grid with selectable rows, where the first cell in each row contained a checkbox, but we wished to expose the checked/unchecked state directly on the focused gridcell element, and potentially on the rowheader cell as well (as it is the most common column users navigate through).

The proposal would be to:

  • Add aria-checked as a supported state on gridcells and rows
  • Add the same checked vs. selected wording that currently exists on treeitems/options to gridcells and rows

Will this require a change to CORE-AAM?

It's possible it might require a change, since all other roles that support aria-checked do note that fact and link to the aria-checked mapping from the role mapping section. I'd personally lean against explicitly adding it though, since we don't do so for aria-selected or other optional states.

Will this require a change to the ARIA authoring guide?

No

@stes-acc
Copy link

Will this require a change to the ARIA authoring guide?

It will provided the fact the guide resolves to explain the difference and the benefits using aria-checked on gridcells ;)

@pkra pkra added this to the ARIA 1.3 milestone Jun 28, 2023
@mcking65
Copy link
Contributor

Will this require a change to the ARIA authoring guide?

It will provided the fact the guide resolves to explain the difference and the benefits using aria-checked on gridcells ;)

Even more than that ...

It would be a significant revision to the grid pattern.

We don't yet have an example that supports row selection, so no updates to existing examples.

@smhigley
Copy link
Contributor Author

One example that shows a use case of checked/unchecked/mixed state on gridcells (not using the aria-checked attribute because of lack of support): https://react.fluentui.dev/?path=/docs/components-datagrid--default

@spectranaut
Copy link
Contributor

Discussed in June 29th meeting

Next steps, Sarah "will add PR and also talk to browser folks".

@msftedad
Copy link

msftedad commented Jan 9, 2024

Hi @spectranaut, Is this issue fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants