From 86f1cc30bcf6cf994bf4f3f6f1cdeced87e55ef9 Mon Sep 17 00:00:00 2001
From: Haoqun Jiang <haoqunjiang@gmail.com>
Date: Tue, 24 Sep 2024 15:58:30 +0800
Subject: [PATCH] chore: need to turn on `checkJs` to avoid false negatives

---
 README.md                                  | 3 ++-
 examples/allow-js/src/App.vue              | 1 +
 examples/allow-js/tsconfig.app.json        | 3 ++-
 examples/minimal/src/main.ts               | 4 ----
 examples/with-jsx-in-vue/tsconfig.app.json | 3 ++-
 examples/with-jsx/tsconfig.app.json        | 3 ++-
 tsconfig.json                              | 1 +
 7 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/README.md b/README.md
index ce5a3ef3..a81a712c 100644
--- a/README.md
+++ b/README.md
@@ -77,7 +77,8 @@ export default [
       // [!DISCOURAGED]
       // Set to `true` to allow plain `<script>` or `<script setup>` blocks.
       // This might result-in false positive or negatives in some rules for `.vue` files.
-      // Note you also need to configure `allowJs: true` in corresponding `tsconfig.json` files.
+      // Note you also need to configure `allowJs: true` and `checkJs: true`
+      // in corresponding `tsconfig.json` files.
       js: false,
 
       // [!STRONGLY DISCOURAGED]
diff --git a/examples/allow-js/src/App.vue b/examples/allow-js/src/App.vue
index 633a5dfe..a3612402 100644
--- a/examples/allow-js/src/App.vue
+++ b/examples/allow-js/src/App.vue
@@ -1,6 +1,7 @@
 <script setup>
 import HelloWorld from './components/HelloWorld.vue'
 import TheWelcome from './components/TheWelcome.vue'
+
 </script>
 
 <template>
diff --git a/examples/allow-js/tsconfig.app.json b/examples/allow-js/tsconfig.app.json
index d139ce2b..97926e79 100644
--- a/examples/allow-js/tsconfig.app.json
+++ b/examples/allow-js/tsconfig.app.json
@@ -11,6 +11,7 @@
       "@/*": ["./src/*"]
     },
 
-    "allowJs": true
+    "allowJs": true,
+    "checkJs": true
   }
 }
diff --git a/examples/minimal/src/main.ts b/examples/minimal/src/main.ts
index fc332b03..0ac3a5ff 100644
--- a/examples/minimal/src/main.ts
+++ b/examples/minimal/src/main.ts
@@ -4,7 +4,3 @@ import { createApp } from 'vue'
 import App from './App.vue'
 
 createApp(App).mount('#app')
-
-let a: number = 1
-a = 'a'
-console.log('a', a)
diff --git a/examples/with-jsx-in-vue/tsconfig.app.json b/examples/with-jsx-in-vue/tsconfig.app.json
index d139ce2b..97926e79 100644
--- a/examples/with-jsx-in-vue/tsconfig.app.json
+++ b/examples/with-jsx-in-vue/tsconfig.app.json
@@ -11,6 +11,7 @@
       "@/*": ["./src/*"]
     },
 
-    "allowJs": true
+    "allowJs": true,
+    "checkJs": true
   }
 }
diff --git a/examples/with-jsx/tsconfig.app.json b/examples/with-jsx/tsconfig.app.json
index 2bdf1188..58077290 100644
--- a/examples/with-jsx/tsconfig.app.json
+++ b/examples/with-jsx/tsconfig.app.json
@@ -10,6 +10,7 @@
     "paths": {
       "@/*": ["./src/*"]
     },
-    "allowJs": true
+    "allowJs": true,
+    "checkJs": true
   }
 }
diff --git a/tsconfig.json b/tsconfig.json
index 96b4894f..b4c2fb53 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -14,6 +14,7 @@
 
 		// Allow JS files to be imported from TS and vice versa
 		"allowJs": true,
+		"checkJs": true,
 
 		// Use correct ESM import behavior
 		"esModuleInterop": true,