Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar API, CreateAvatar is missing required fields. #125

Open
binn opened this issue Dec 20, 2021 · 0 comments
Open

Avatar API, CreateAvatar is missing required fields. #125

binn opened this issue Dec 20, 2021 · 0 comments
Labels
Priority: High High priority, this ideally needs to be fixed first Type: Bug There is a **factual incorrectness** in the spec

Comments

@binn
Copy link

binn commented Dec 20, 2021

Fields missing:

  • platform: string
  • tags: string[]
  • assetVersion: string ("1", "2" etc)
  • updated_at : some weird Date
  • created_at: some weird Date

The weird date is in this format: 12/12/2021 1:23:43 AM, Not sure if it's in 00 or 0 number format.

The current implementation simply uploads an ID, name, description, image, asset, releaseStatus, as well as version, which is an invalid field.

The Unity SDK specifically sends up the current author's ID and name, as well as a thumbnailImageUrl (when it is an upload to android) (or perhaps when uploading a second version?), as well as a totalLikes and totalVisits. I believe these values can all be omitted. I have not documented the thumbnailImageUrl behavior yet. My theory is that their ApiFile models have these fields so they get sent up anyway when serialized, but the API only looks for other fields. Whether or not it is good to mimic SDK behavior when uploading clients is up to the end-user to decide.

@Foorack Foorack added Priority: High High priority, this ideally needs to be fixed first Type: Bug There is a **factual incorrectness** in the spec labels Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High High priority, this ideally needs to be fixed first Type: Bug There is a **factual incorrectness** in the spec
Development

No branches or pull requests

2 participants