Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port indentation logic to SMIE #7

Open
bbatsov opened this issue Aug 18, 2013 · 8 comments
Open

Port indentation logic to SMIE #7

bbatsov opened this issue Aug 18, 2013 · 8 comments

Comments

@bbatsov
Copy link
Contributor

bbatsov commented Aug 18, 2013

SMIE is the way to handle indentation in recent Emacs editions http://www.gnu.org/software/emacs/manual/html_node/elisp/SMIE.html AFAIK all major modes should start using it at some point instead of rolling out their custom solutions.

@swsnr
Copy link
Contributor

swsnr commented Aug 18, 2013

@bbatsov 👍

@swsnr
Copy link
Contributor

swsnr commented Mar 11, 2014

For reference, the official Puppet grammar… looks like a terrible beast.

@bbatsov
Copy link
Contributor Author

bbatsov commented Mar 11, 2014

I've seen worse. I guess only a limited subset of the grammar needs porting (something covering the most common use-cases). One problem with using SMIE, however, is that it's not quite the same in each Emacs release - the version in 24.4 has many improvements AFAIK (because a bunch of prominent packages were rewritten to use it) and that might be problematic on older Emacsen. If the version in 24.1 has too many shortcomings I guess it won't be wise to use SMIE.

@swsnr
Copy link
Contributor

swsnr commented Mar 11, 2014

@bbatsov I'd start with an optional switch to enable SMIE indentation anyway. I don't know SMIE, and I don't have enough confidence into my grammar skills to make an SMIE variant the default right away ;)

@tcuthbert
Copy link

Hey guys, I don't mean to be a pain but when do you think the new indentation system will be ready?

@swsnr
Copy link
Contributor

swsnr commented Nov 24, 2014

@tcuthbert We have no ETA. We are busy with many tasks and projects, and SMIE isn't the easiest thing to understand or use.

@tcuthbert
Copy link

no problems, are there any workarounds at this point? (I mainly want to keep consistency with my parenthesis alignments) any hackish suggestions welcome. Sorry If this is the wrong forum for such a query, let me know if there's a more suitable one (irc, mailing list etc)

@swsnr
Copy link
Contributor

swsnr commented Nov 24, 2014

@tcuthbert There are no workarounds that I'm aware, but I also never really read the old indentation code.

The best “workaround” for this issue is to help use getting SMIE done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants