Skip to content

Commit bf3d2c3

Browse files
committed
Update comment, now that this actually works
1 parent 7d84287 commit bf3d2c3

File tree

1 file changed

+1
-3
lines changed
  • app/packages/looker/src/elements/common

1 file changed

+1
-3
lines changed

app/packages/looker/src/elements/common/looker.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ export class LookerElement<State extends BaseState> extends BaseElement<
3838
if (enabled) {
3939
matchedControl.action(update, dispatchEvent, e.key, e.shiftKey);
4040

41-
// The below change does prevent closing the modal *also* clearing the selected samples
42-
// But... hitting escape when the modal is *not* open no longer always clears selection
43-
// If this is a Modal, we don't want this event to bubble up to the Grid
41+
// If this is a Modal, we don't want Escape to bubble up to the Grid
4442
// Hack: `lookerOptions` only sets showControl=true when a Modal
4543
const isModal = state.options.showControls === true;
4644
if (e.key === "Escape" && isModal) {

0 commit comments

Comments
 (0)