Skip to content

Commit 32cbbcd

Browse files
authored
Merge pull request #6468 from voxel51/feat/ha-ff
add feature flag for human annotation
2 parents 83a277d + 68e60a4 commit 32cbbcd

File tree

5 files changed

+17
-4
lines changed

5 files changed

+17
-4
lines changed

app/packages/core/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
},
1111
"dependencies": {
1212
"@fiftyone/components": "*",
13+
"@fiftyone/feature-flags": "*",
1314
"@fiftyone/flashlight": "*",
1415
"@fiftyone/looker": "*",
1516
"@fiftyone/map": "*",
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import { readOnly } from "@fiftyone/state";
22
import { useRecoilValue } from "recoil";
3+
import { FeatureFlag, useFeature } from "@fiftyone/feature-flags";
34

45
export default function useCanAnnotate() {
5-
return !useRecoilValue(readOnly);
6+
const isReadOnly = useRecoilValue(readOnly);
7+
const isAnnotationEnabled = useFeature({
8+
feature: FeatureFlag.EXPERIMENTAL_ANNOTATION,
9+
});
10+
return !isReadOnly && isAnnotationEnabled;
611
}
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
/**
22
* Enumeration of active feature flags.
33
*/
4-
export enum FeatureFlag {}
4+
export enum FeatureFlag {
5+
// experimental sample annotation features
6+
EXPERIMENTAL_ANNOTATION = "VFF_EXP_ANNOTATION",
7+
}

app/yarn.lock

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2450,6 +2450,7 @@ __metadata:
24502450
resolution: "@fiftyone/core@workspace:packages/core"
24512451
dependencies:
24522452
"@fiftyone/components": "npm:*"
2453+
"@fiftyone/feature-flags": "npm:*"
24532454
"@fiftyone/flashlight": "npm:*"
24542455
"@fiftyone/looker": "npm:*"
24552456
"@fiftyone/map": "npm:*"
@@ -2546,7 +2547,7 @@ __metadata:
25462547
languageName: unknown
25472548
linkType: soft
25482549

2549-
"@fiftyone/feature-flags@workspace:packages/feature-flags":
2550+
"@fiftyone/feature-flags@npm:*, @fiftyone/feature-flags@workspace:packages/feature-flags":
25502551
version: 0.0.0-use.local
25512552
resolution: "@fiftyone/feature-flags@workspace:packages/feature-flags"
25522553
dependencies:

fiftyone/internal/features/flags.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,8 @@
88

99
from typing import Literal
1010

11-
FeatureFlag = Literal["placeholder"]
11+
FeatureFlag = Literal[
12+
# experimental sample annotation features
13+
"VFF_EXP_ANNOTATION",
14+
]
1215
"""Enumeration of active feature flags."""

0 commit comments

Comments
 (0)