Skip to content

Commit 47d1161

Browse files
authored
do not export spans by default on benchmarks (#5003)
Disable exporting spans to grafana by default. Kept the functionality because it should work with all otel endpoints, so we can use a jaeger or datadog trace viewer when we want to debug benchmarks with traces Signed-off-by: Onur Satici <[email protected]>
1 parent fd130ec commit 47d1161

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

.github/workflows/sql-benchmarks.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ jobs:
194194
target/release_debug/query_bench ${{ matrix.subcommand }} \
195195
-d gh-json \
196196
--targets ${{ matrix.targets }} \
197-
--export-spans \
198197
${{ matrix.scale_factor }} \
199198
--delete-duckdb-database \
200199
-o results.json
@@ -213,7 +212,6 @@ jobs:
213212
target/release_debug/query_bench ${{ matrix.subcommand }} \
214213
--use-remote-data-dir ${{ matrix.remote_storage }} \
215214
--targets ${{ matrix.targets }} \
216-
--export-spans \
217215
${{ matrix.scale_factor }} \
218216
-d gh-json \
219217
--delete-duckdb-database \

0 commit comments

Comments
 (0)