Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline love #4

Open
forresto opened this issue Jul 30, 2014 · 9 comments
Open

timeline love #4

forresto opened this issue Jul 30, 2014 · 9 comments

Comments

@forresto
Copy link

Thinking about giving this some love to integrate it with https://github.com/noflo/noflo-ui . I'll pretty much just use the GUI and then make a new component in https://github.com/noflo/noflo-tween that actually drives the tweens.

If there is anything you have been planning or putting off, I'll try to contribute changes.

@forresto
Copy link
Author

Some ideas:

  • expand track to see function line representing tween / drag keyframe up and down as well
  • add / remove / rename tracks
  • touch (not a huge priority, might require another skin to make the elements bigger)
  • zoom wider /// 60fps animation, or more for web audio fun
  • visualize frames

@vorg
Copy link
Owner

vorg commented Jul 30, 2014

Hi,

I have not pushed:

  • edge cases timing fixes
  • onStart/onEnd events
  • probably more
  • optional nodejs module exports

Will review tomorrow and push

Sent from Mailbox

On Wed, Jul 30, 2014 at 7:45 PM, Forrest Oliphant
[email protected] wrote:

Some ideas:

  • expand track to see function line representing tween / drag keyframe up and down as well
  • add / remove / rename tracks
  • touch (not a huge priority, might require another skin to make the elements bigger)
  • zoom wider /// 60fps animation, or more for web audio fun

* visualize frames

Reply to this email directly or view it on GitHub:
#4 (comment)

@forresto
Copy link
Author

Sweet, thanks Marcin!
If it works with browserify that'll be nice 👍

@vorg
Copy link
Owner

vorg commented Jul 30, 2014

Have you looked at https://github.com/idflood/timeline.js/commits/dev ? Seems like it has quite a lot of ui / integration changes.

@forresto
Copy link
Author

Hmm looks like good stuff there. Will you merge his stuff?

@idflood is your dev branch stable?

@vorg
Copy link
Owner

vorg commented Jul 30, 2014

@idflood pull looks ok. I'll cherry pick from his other upgrades too.

@idflood
Copy link

idflood commented Jul 31, 2014

The dev branch is stable I think but the commits could have been better. Typically the "enable parameters and add some color options" add 2 features. The parameters one is important I think but the color option is not necessary. So yes, it may be a good idea to cherry pick what you need : )

And don't hesitate to ask if you have any question regarding some commits.

@vorg
Copy link
Owner

vorg commented Jul 31, 2014

@forresto Hi, started updating stuff and broke looping in the process. I'll continue tomorrow..

@vorg
Copy link
Owner

vorg commented Jul 31, 2014

Ok, I fixed the looping but there is more work to be done with callbacks. Next will be UI customization based on @idflood work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants