Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open project Ideas #40

Open
jasminechau2 opened this issue Jun 4, 2018 · 16 comments
Open

Open project Ideas #40

jasminechau2 opened this issue Jun 4, 2018 · 16 comments

Comments

@jasminechau2
Copy link
Collaborator

jasminechau2 commented Jun 4, 2018

Here are some things I thought off after seeing everyone else ideas and stuff I decided I would like to work on:

  • The ability to block and delete users.
  • Add the ability to chat in a different language
  • Liking messages
    I do like to help Guillermo with a notification system. As well as help Veronica with liking/deleting messages and maybe implementing that to also deleting conversations.
@yebrahim
Copy link
Collaborator

yebrahim commented Jun 4, 2018

Sounds great.

How would a notifications system work?

@lealgamb
Copy link
Collaborator

lealgamb commented Jun 4, 2018

Really like these ideas.

@vocatwk
Copy link
Owner

vocatwk commented Jun 5, 2018

These sound great!

@jasminechau2
Copy link
Collaborator Author

I was thinking that when the user sends a message it would store an object containing the user's name, the person the user sent a message to and the location of the message. When the message is sent the receiving user would see these notifications in a drop down menu type format and when clicked it takes them to the message and then the notification gets deleted.

@yebrahim
Copy link
Collaborator

yebrahim commented Jun 5, 2018

If we use the new Event entity to store all kinds of events in the datastore, is it enough then to just store a timestamp of the "last seen event" in the User entity? This makes it easy to decide what qualifies as an "unseen event," which is essentially what should show up in a notifications page. Does this work?
@lealgamb and @vocatwk your feedback would be appreciated here too, since you're more familiar with the implementation details.

@lealgamb
Copy link
Collaborator

lealgamb commented Jun 6, 2018

I think the Event entity would be useful in doing this. Alternatively we can keep a counter of the number of seen events, which is essentially the index of the event, but using the timestamp might be more accurate.

I'm wondering how the notification system would work with the activity feed? It might make more sense to just use pagination/infinite scroll for the feed instead of basing it on last seen event if we implement a notification system.

@yebrahim
Copy link
Collaborator

yebrahim commented Jun 6, 2018

For a start, we can have the activity feed only show you events since your last seen event?

@lealgamb
Copy link
Collaborator

lealgamb commented Jun 7, 2018

Okay, I'll do that. If a user isn't logged in then should all of the events be displayed?

@yebrahim
Copy link
Collaborator

yebrahim commented Jun 7, 2018

I might've missed the result of our chat conversation, but I was in favor of making all features require login.
If you guys agree, we don't have to start by doing this to begin with, we can work incrementally toward it.
If you still prefer users to see content without being logged in, then I think they should probably see all events like you said.

@lealgamb
Copy link
Collaborator

lealgamb commented Jun 7, 2018

I'm fine with either one.

@jasminechau2
Copy link
Collaborator Author

I think it hiding everything until login may make it easier to mark which events are seen and unseen

@yebrahim
Copy link
Collaborator

yebrahim commented Jun 7, 2018

@vocatwk does this sound good to you? Should we open an issue to track the work to block signed out users from using the app before signing in?

@vocatwk
Copy link
Owner

vocatwk commented Jun 8, 2018

Oops, sorry guys. I had missed this conversation. I'm defintely in favor of requring login for everything.

@yebrahim
Copy link
Collaborator

yebrahim commented Jun 9, 2018

Great. We should probably get that our of the way first so we can proceed with private chats and notifications work. I'll open an issue, any takers?

@yebrahim
Copy link
Collaborator

yebrahim commented Jun 9, 2018

#49

@vocatwk
Copy link
Owner

vocatwk commented Jun 9, 2018

Yeah, I can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants