Skip to content

Commit 232c9c5

Browse files
committed
Guard aux residual collection & update supported models docs
Signed-off-by: YoussefEssDS <[email protected]>
1 parent 80fbcca commit 232c9c5

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

docs/models/supported_models.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,7 @@ These models primarily accept the [`LLM.generate`](./generative_models.md#llmgen
676676
| `Ovis` | Ovis2, Ovis1.6 | T + I<sup>+</sup> | `AIDC-AI/Ovis2-1B`, `AIDC-AI/Ovis1.6-Llama3.2-3B`, etc. | | ✅︎ |
677677
| `Ovis2_5` | Ovis2.5 | T + I<sup>+</sup> + V | `AIDC-AI/Ovis2.5-9B`, etc. | | |
678678
| `PaliGemmaForConditionalGeneration` | PaliGemma, PaliGemma 2 | T + I<sup>E</sup> | `google/paligemma-3b-pt-224`, `google/paligemma-3b-mix-224`, `google/paligemma2-3b-ft-docci-448`, etc. | | ✅︎ |
679+
| `PanguEmbeddedForCausalLM` | openPangu Embedded | `FreedomIntelligence/openPangu-Embedded-7B` | | ✅︎ |
679680
| `Phi3VForCausalLM` | Phi-3-Vision, Phi-3.5-Vision | T + I<sup>E+</sup> | `microsoft/Phi-3-vision-128k-instruct`, `microsoft/Phi-3.5-vision-instruct`, etc. | | ✅︎ |
680681
| `Phi4MMForCausalLM` | Phi-4-multimodal | T + I<sup>+</sup> / T + A<sup>+</sup> / I<sup>+</sup> + A<sup>+</sup> | `microsoft/Phi-4-multimodal-instruct`, etc. | ✅︎ | ✅︎ |
681682
| `Phi4MultimodalForCausalLM` | Phi-4-multimodal (HF Transformers) | T + I<sup>+</sup> / T + A<sup>+</sup> / I<sup>+</sup> + A<sup>+</sup> | `microsoft/Phi-4-multimodal-instruct` (with revision `refs/pr/70`), etc. | ✅︎ | ✅︎ |

tests/models/registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def check_available_online(
371371
),
372372
"OuroForCausalLM": _HfExamplesInfo("ByteDance/Ouro-1.4B", trust_remote_code=True),
373373
"PanguEmbeddedForCausalLM": _HfExamplesInfo(
374-
"FreedomIntelligence/openPangu-Embedded-7B, trust_remote_code=True"
374+
"FreedomIntelligence/openPangu-Embedded-7B", trust_remote_code=True
375375
),
376376
"PersimmonForCausalLM": _HfExamplesInfo("adept/persimmon-8b-chat"),
377377
"PhiForCausalLM": _HfExamplesInfo("microsoft/phi-2"),

vllm/model_executor/models/pangu.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,9 @@ def forward(
326326

327327
aux_hidden_states: list[torch.Tensor] = []
328328
for idx, layer in enumerate(self.layers[self.start_layer : self.end_layer]):
329-
if self.start_layer + idx in self.aux_hidden_state_layers:
329+
if residual is None:
330+
aux_hidden_states.append(hidden_states)
331+
else:
330332
aux_hidden_states.append(hidden_states + residual)
331333
hidden_states, residual = layer(positions, hidden_states, residual)
332334

0 commit comments

Comments
 (0)