From 936ce1b2df80369384ae1942d860a44b93aaaa38 Mon Sep 17 00:00:00 2001 From: Prashant Gupta Date: Thu, 25 Sep 2025 10:15:38 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5=20rip=20out=20VLLM=5FSPYRE=5FTEST?= =?UTF-8?q?=5FBACKEND=5FLIST?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We anyway use markers for selecting the tests so this env var wasn't useful Signed-off-by: Prashant Gupta --- _local_envs_for_test.sh | 1 - tests/spyre_util.py | 8 +++----- tests/utils/test_spyre_backend_list.py | 21 --------------------- 3 files changed, 3 insertions(+), 27 deletions(-) delete mode 100644 tests/utils/test_spyre_backend_list.py diff --git a/_local_envs_for_test.sh b/_local_envs_for_test.sh index 098d87d83..829fd8cfd 100644 --- a/_local_envs_for_test.sh +++ b/_local_envs_for_test.sh @@ -14,7 +14,6 @@ export VLLM_SPYRE_DYNAMO_BACKEND=eager # This makes debugging easy on local setup export VLLM_ENABLE_V1_MULTIPROCESSING=0 -export VLLM_SPYRE_TEST_BACKEND_LIST=eager # We have to use `HF_HUB_OFFLINE=1` otherwise vllm might try to download a # different version of the model using HF API which might not work locally export HF_HUB_OFFLINE=1 diff --git a/tests/spyre_util.py b/tests/spyre_util.py index 8e95212a2..203edbed9 100644 --- a/tests/spyre_util.py +++ b/tests/spyre_util.py @@ -197,14 +197,12 @@ def get_spyre_model_dir_path() -> Path: return Path(model_dir_path) -# get model backends from env or default to all and add pytest markers +# add pytest markers to supported different backends def get_spyre_backend_list(): - user_backend_list = os.environ.get("VLLM_SPYRE_TEST_BACKEND_LIST", - "eager,inductor,sendnn") + backend_list = ["eager", "inductor", "sendnn"] backends = [] - for backend in user_backend_list.split(","): - backend = backend.strip() + for backend in backend_list: marks = [] if backend == "eager": marks = [pytest.mark.cpu] diff --git a/tests/utils/test_spyre_backend_list.py b/tests/utils/test_spyre_backend_list.py deleted file mode 100644 index 7b818c0ac..000000000 --- a/tests/utils/test_spyre_backend_list.py +++ /dev/null @@ -1,21 +0,0 @@ -import pytest -from spyre_util import get_spyre_backend_list - - -@pytest.mark.utils -@pytest.mark.cpu -def test_get_spyre_backend_list(monkeypatch): - ''' - Ensure we return the backend list correctly - ''' - with monkeypatch.context() as m: - m.setenv("VLLM_SPYRE_TEST_BACKEND_LIST", "eager,inductor,sendnn") - backend_list = get_spyre_backend_list() - assert backend_list[0].values[0] == "eager" - assert backend_list[1].values[0] == "inductor" - assert backend_list[2].values[0] == "sendnn" - - with monkeypatch.context() as m: - m.setenv("VLLM_SPYRE_TEST_BACKEND_LIST", "sendnn") - backend_list = get_spyre_backend_list() - assert backend_list[0].values[0] == "sendnn"