From 9eb3e465cc8198439f9a43a362fcce80484f0c1d Mon Sep 17 00:00:00 2001 From: Prashant Gupta Date: Mon, 18 Aug 2025 14:34:19 -0700 Subject: [PATCH 1/3] =?UTF-8?q?=E2=9C=85=20add=20marker=20to=20skip=20unsu?= =?UTF-8?q?pported=20compiler=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Prashant Gupta --- tests/conftest.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/conftest.py b/tests/conftest.py index bae6eb5b8..3725eef14 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -25,6 +25,8 @@ def pytest_collection_modifyitems(config, items): _skip_all_cb_and_fp8_tests(items) + _skip_unsupported_compiler_tests(config, items) + def _mark_all_e2e(items): """Mark all tests within the e2e package with the e2e marker""" @@ -77,6 +79,21 @@ def _skip_all_cb_and_fp8_tests(items): item.add_marker(skip_marker) +def _skip_unsupported_compiler_tests(config, items): + """Skip all tests that need compiler changes to run. + This can be relaxed once the compiler changes are in place + """ + + markexpr = config.option.markexpr + if "compiler_support_16k" in markexpr: + return # let pytest handle the collection logic + + skip_marker = pytest.mark.skip(reason="Needs compiler changes") + for item in items: + if "compiler_support_16k" in item.keywords: + item.add_marker(skip_marker) + + @pytest.fixture(autouse=True) def init_test_http_connection(): # pytest_asyncio may use a different event loop per test From 41cd9d7475137bfc0707e5c2e0faf5862c959b77 Mon Sep 17 00:00:00 2001 From: Prashant Gupta Date: Mon, 18 Aug 2025 14:35:07 -0700 Subject: [PATCH 2/3] =?UTF-8?q?=E2=9C=85=20add=20marker=20to=20skip=20unsu?= =?UTF-8?q?pported=20compiler=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Prashant Gupta --- tests/e2e/test_spyre_cb.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/e2e/test_spyre_cb.py b/tests/e2e/test_spyre_cb.py index 2cdf03849..777084ce8 100644 --- a/tests/e2e/test_spyre_cb.py +++ b/tests/e2e/test_spyre_cb.py @@ -109,10 +109,12 @@ def test_api_cb_generates_correct_max_tokens( assert response.usage.completion_tokens == max_tokens +@pytest.mark.compiler_support_16k @pytest.mark.cb @pytest.mark.parametrize("model", get_spyre_model_list()) @pytest.mark.parametrize( - "backend", [pytest.param("sendnn", marks=pytest.mark.spyre, id="sendnn")]) + "backend", [pytest.param("sendnn", marks=pytest.mark.spyre, id="sendnn")] +) @pytest.mark.parametrize( "tp_size", [ @@ -184,6 +186,7 @@ def test_long_context_batches( force_engine_shutdown(vllm_model) +@pytest.mark.compiler_support_16k @pytest.mark.spyre @pytest.mark.cb @pytest.mark.parametrize( From c6ebdfe7d124af958532df2d060dfad987382257 Mon Sep 17 00:00:00 2001 From: Prashant Gupta Date: Mon, 18 Aug 2025 14:42:02 -0700 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=8E=A8=20skip=20only=20for=20spyre?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Prashant Gupta --- tests/conftest.py | 2 +- tests/e2e/test_spyre_cb.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index 3725eef14..f3ac3f12d 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -90,7 +90,7 @@ def _skip_unsupported_compiler_tests(config, items): skip_marker = pytest.mark.skip(reason="Needs compiler changes") for item in items: - if "compiler_support_16k" in item.keywords: + if "spyre" in item.keywords and "compiler_support_16k" in item.keywords: item.add_marker(skip_marker) diff --git a/tests/e2e/test_spyre_cb.py b/tests/e2e/test_spyre_cb.py index 777084ce8..c1d25c5b8 100644 --- a/tests/e2e/test_spyre_cb.py +++ b/tests/e2e/test_spyre_cb.py @@ -113,8 +113,7 @@ def test_api_cb_generates_correct_max_tokens( @pytest.mark.cb @pytest.mark.parametrize("model", get_spyre_model_list()) @pytest.mark.parametrize( - "backend", [pytest.param("sendnn", marks=pytest.mark.spyre, id="sendnn")] -) + "backend", [pytest.param("sendnn", marks=pytest.mark.spyre, id="sendnn")]) @pytest.mark.parametrize( "tp_size", [