-
Notifications
You must be signed in to change notification settings - Fork 27
[CB] Support batch size 1 for decode, simplify warmup #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
419c471
relax decode batch size > 1 constraint, adapt warmup
yannicks1 2d0e675
enable batch size 1 tests
yannicks1 149f96f
revert warmup changes.
yannicks1 2f11200
Merge branch 'main' into ysc-batch-1
yannicks1 293c33c
fix warmup for batch size 1
yannicks1 00a2fbe
Merge branch 'main' into ysc-batch-1
yannicks1 0cb280a
Merge branch 'main' into ysc-batch-1
yannicks1 04ff0a9
Merge branch 'main' into ysc-batch-1
yannicks1 aad5e91
Merge branch 'main' into ysc-batch-1
yannicks1 ce6cf2b
setting torch.fx.experimental config
yannicks1 2104ba7
adapt warmup to do only one prefill and one decode
yannicks1 12a045b
add comment, small refactor
yannicks1 1efc54a
update comment
yannicks1 53ce8a9
removing (now obsolete) hack for pseudo batch size 1.
yannicks1 89e4a28
Merge branch 'main' into ysc-batch-1
yannicks1 a62818f
remove test case
yannicks1 594473a
Merge branch 'main' into ysc-batch-1
yannicks1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was just convenient for testing. think I will remove to not make the test suite any longer. @joerunde what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add one extra test with it instead of parameterizing it here (for unnecessary combinations with other params) so that it gets tested at least once every iteration. But then it's repeated code so there's that 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, honestly I don't know whats better here 😄 @joerunde any opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, the tests right now take a ton of CI time both here and on jenkins, and since
--max-num-seqs=1isn't really a setting that anybody would use in practice, I'd be fine not testing it directly. All the existing CB tests should cover the warmup change, which is the important thing to not break