Skip to content

Add CLI args and config #51

@joerunde

Description

@joerunde

Based on discussions here: #47

It seems like we'll want a way to add spyre-specific cli arguments, otherwise we'll have to continue putting everything in environment variables. We also don't currently have a way to reliably create a configuration object in one place and have it propagate to all of the worker processes.

The vllm_tgis_adapter works around the CLI args problem by creating its own entrypoint, which adds arguments to vllm's argparser and monkeypatches a few things before booting vllm. We'd like to not have to do that here: both maintaining a seamless plugin that looks and feels like any other vllm install and minimizing maintenance overhead as vllm moves forward are important to us.

We'll want to discuss with the community, and see what the vllm-ascend maintainers think as well

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions