Skip to content

Commit b34d290

Browse files
committed
remove resolved comments
Signed-off-by: Sophie du Couédic <[email protected]>
1 parent db9bf5c commit b34d290

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

tests/e2e/test_spyre_cb.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -700,21 +700,16 @@ def get_params_test_remove_left_padding():
700700
},
701701
{
702702
# Prefill sequence 2
703-
# TODO @Yannick, should the left padding ideally already be removed?
704703
"step": 42,
705-
"tkv": 103, # <-- should be 64?
704+
"tkv": 103, # TODO update after the new changes are implemented
706705
"waiting": [],
707706
"running": ["2", "1"],
708707
"request_outputs": ["2"]
709708
},
710709
{
711710
# Decode sequences 1 and 2
712-
# @Yannick
713-
# That value (40) is a bit odd to see since we are used that for the
714-
# first block, the two prompts are padded to the right
715-
# it is not necessarily a problem though, but might be confusing
716711
"step": 43,
717-
"tkv": 40, # 104 - 64 = 40
712+
"tkv": 40,
718713
"waiting": [],
719714
"running": ["2", "1"],
720715
"request_outputs": ["2", "1"]

0 commit comments

Comments
 (0)