New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use `setuptools_scm` to replace `STACK_VERSION` in the router #87

Closed

gaocegege opened this issue Feb 8, 2025 · 0 comments · Fixed by #155

Labels

good first issue help wanted

Collaborator

gaocegege commented Feb 8, 2025 •

edited

Loading

Currently, we have a hard-coded version in the router.

production-stack/src/vllm_router/router.py

Line 31 in c8cdf9d

STACK_VERSION = "0.0.1"

We can utilize setuptools_scm to eliminate the hard-coded string and dynamically output the pip package version.

For reference, you can check the vLLM implementation here.

gaocegege added good first issue help wanted labels

gaocegege mentioned this issue

[router] setuptools_scm to support version argument #155

Merged

ApostaC closed this as completed in #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment