From def8e4d2f347c5319b743dfb6c66c0131405070d Mon Sep 17 00:00:00 2001 From: Jiaxin Shan Date: Sun, 2 Mar 2025 10:03:50 -0800 Subject: [PATCH] Disable ENABLE_PROBES_INJECTION in correct way MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix env error caused by helm set command, use —set-string for env bool Signed-off-by: Jiaxin Shan --- config/dependency/kuberay-operator/README.md | 2 +- config/dependency/kuberay-operator/templates/deployment.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/dependency/kuberay-operator/README.md b/config/dependency/kuberay-operator/README.md index 6fea4127..541889c6 100644 --- a/config/dependency/kuberay-operator/README.md +++ b/config/dependency/kuberay-operator/README.md @@ -3,7 +3,7 @@ Commands to export manifest from helm package. After you got manifest, copy to this folder. ```shell -helm template kuberay-operator kuberay/kuberay-operator --namespace aibrix-system --version 1.2.1 --include-crds --set env[0].name=ENABLE_PROBES_INJECTION --set env[0].value=\"false\" --set fullnameOverride=kuberay-operator --set featureGates[0].name=RayClusterStatusConditions --set featureGates[0].enabled=true --output-dir ./config/dependency +helm template kuberay-operator kuberay/kuberay-operator --namespace aibrix-system --version 1.2.1 --include-crds --set env[0].name=ENABLE_PROBES_INJECTION --set-string env[0].value=false --set fullnameOverride=kuberay-operator --set featureGates[0].name=RayClusterStatusConditions --set featureGates[0].enabled=true --output-dir ./config/dependency ``` If you use zsh, please use `noglob helm ...` to skip the brace check. diff --git a/config/dependency/kuberay-operator/templates/deployment.yaml b/config/dependency/kuberay-operator/templates/deployment.yaml index 25125120..68119b8b 100644 --- a/config/dependency/kuberay-operator/templates/deployment.yaml +++ b/config/dependency/kuberay-operator/templates/deployment.yaml @@ -51,7 +51,7 @@ spec: protocol: TCP env: - name: ENABLE_PROBES_INJECTION - value: '"false"' + value: "false" livenessProbe: httpGet: path: /metrics