Add check for containers ready #787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Gupta <[email protected]>
Signed-off-by: Varun Gupta <[email protected]>
kerthcet
reviewed
Mar 4, 2025
| @@ -39,7 +39,7 @@ func IsPodTerminating(pod *v1.Pod) bool { | |||
|
|
|||
| // IsPodReady returns true if a pod is ready; false otherwise. | |||
| func IsPodReady(pod *v1.Pod) bool { | |||
| return IsPodReadyConditionTrue(pod.Status) | |||
| return IsPodReadyConditionTrue(pod.Status) && IsContainerReadyConditionTrue(pod.Status) | |||
There was a problem hiding this comment.
Let's update the comment as well.
| // GetPodReadyCondition extracts the pod ready condition from the given status and returns that. | ||
| // Returns nil if the condition is not present. | ||
| func GetPodReadyCondition(status v1.PodStatus) *v1.PodCondition { | ||
| _, condition := GetPodCondition(&status, v1.PodReady) | ||
| return condition | ||
| } | ||
|
|
||
| // GetContainersReadyCondition extracts the containers ready condition from the given status and returns that. | ||
| // Returns nil if the condition is not present. | ||
| func GetContainersReadyCondition(status v1.PodStatus) *v1.PodCondition { |
There was a problem hiding this comment.
Shouldn't we check all the containers ready?
There was a problem hiding this comment.
it check the pod condition, still pod level. I notice it's probably my mistake and I forgot double check the target-pod. #781 so we do not have code issue and I think we do not need this PR. Pod will be ready only after all container become ready. I was talking out running but not ready in original issue.
status:
conditions:
- lastProbeTime: null
lastTransitionTime: "2025-03-04T03:48:14Z"
status: "True"
type: Initialized
- lastProbeTime: null
lastTransitionTime: "2025-03-04T03:51:56Z"
status: "True"
type: Ready
- lastProbeTime: null
lastTransitionTime: "2025-03-04T03:51:56Z"
status: "True"
type: ContainersReady
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Along with pod ready condition check, add check for containers ready as well.
Related Issues
Resolves: #781
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.