Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enable licensecheck scripts to check for license headers #28

Closed
Jeffwan opened this issue Jul 13, 2024 · 2 comments
Closed

[CI] Enable licensecheck scripts to check for license headers #28

Jeffwan opened this issue Jul 13, 2024 · 2 comments
Assignees
@happyandslow
Labels
area/testing Issues or PRs related to testing good first issue Good for newcomers help wanted Extra attention is needed kind/misc priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.1.0-rc.0

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 13, 2024 •
edited
Loading

Let's add a make command for the header checking

We could use similar way like external-dns does.

https://github.com/kubernetes-sigs/external-dns/blob/eadce08c0984da2e5b029843562f77c24d2abea2/Makefile#L51-L65C7
@Jeffwan Jeffwan added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 13, 2024
@Jeffwan Jeffwan modified the milestones: v0.1.0, v0.1.0-rc.0 Jul 29, 2024
@Jeffwan Jeffwan added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/testing Issues or PRs related to testing kind/misc labels Jul 29, 2024
@Jeffwan Jeffwan changed the title Enable licensecheck scripts to check for license headers [CI] Enable licensecheck scripts to check for license headers Jul 29, 2024
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 29, 2024 •
edited
Loading

/cc @happyandslow will help with this one.

@Jeffwan Jeffwan mentioned this issue Jul 29, 2024
Closed
@happyandslow happyandslow mentioned this issue Aug 6, 2024
Merged
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Aug 29, 2024

make lint-all has been added in CI. #74 also contributes to this

@Jeffwan Jeffwan closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@happyandslow happyandslow

Labels
area/testing Issues or PRs related to testing good first issue Good for newcomers help wanted Extra attention is needed kind/misc priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.1.0-rc.0
Development

No branches or pull requests
2 participants
@Jeffwan @happyandslow