From e9d0b402aedcc6b17ce60361fd97d8c334112237 Mon Sep 17 00:00:00 2001
From: varungupta <varungupta@BYTEDANCE.COM>
Date: Wed, 28 Aug 2024 11:19:28 -0700
Subject: [PATCH] fix lint errors

---
 pkg/cache/cache.go                               | 16 +++++++++++-----
 .../modeladapter/scheduling/leastadapters.go     |  6 +++---
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/pkg/cache/cache.go b/pkg/cache/cache.go
index 6e1157e1..d09f61d2 100644
--- a/pkg/cache/cache.go
+++ b/pkg/cache/cache.go
@@ -79,7 +79,9 @@ func NewCache(stopCh <-chan struct{}) *Cache {
 			panic(err)
 		}
 
-		v1alpha1scheme.AddToScheme(scheme.Scheme)
+		if err := v1alpha1scheme.AddToScheme(scheme.Scheme); err != nil {
+			panic(err)
+		}
 
 		k8sClientSet, err := kubernetes.NewForConfig(config)
 		if err != nil {
@@ -116,17 +118,21 @@ func NewCache(stopCh <-chan struct{}) *Cache {
 			podToModelAdapterMapping: map[string]map[string]struct{}{},
 		}
 
-		podInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
+		if _, err := podInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
 			AddFunc:    instance.addPod,
 			UpdateFunc: instance.updatePod,
 			DeleteFunc: instance.deletePod,
-		})
+		}); err != nil {
+			panic(err)
+		}
 
-		modeInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
+		if _, err = modeInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
 			AddFunc:    instance.addModel,
 			UpdateFunc: instance.updateModel,
 			DeleteFunc: instance.deleteModel,
-		})
+		}); err != nil {
+			panic(err)
+		}
 	})
 
 	return &instance
diff --git a/pkg/controller/modeladapter/scheduling/leastadapters.go b/pkg/controller/modeladapter/scheduling/leastadapters.go
index 7b797450..f3cdf148 100644
--- a/pkg/controller/modeladapter/scheduling/leastadapters.go
+++ b/pkg/controller/modeladapter/scheduling/leastadapters.go
@@ -38,7 +38,7 @@ func NewLeastAdapters(c *cache.Cache) Scheduler {
 
 func (r leastAdapters) SelectPod(ctx context.Context, pods []v1.Pod) (*v1.Pod, error) {
 	modelAdapterCountMin := math.MaxInt
-	selectedPod := &v1.Pod{}
+	selectedPod := v1.Pod{}
 	podMap := r.cache.GetPods()
 	podToModelAdapterMapping := r.cache.GetPodToModelAdapterMapping()
 
@@ -49,12 +49,12 @@ func (r leastAdapters) SelectPod(ctx context.Context, pods []v1.Pod) (*v1.Pod, e
 
 		modelAdapters := podToModelAdapterMapping[pod.Name]
 		if len(modelAdapters) < modelAdapterCountMin {
-			selectedPod = &pod
+			selectedPod = pod
 			modelAdapterCountMin = len(modelAdapters)
 		}
 	}
 
 	klog.Infof("pod selected with least model adapters: %s", selectedPod.Name)
 
-	return selectedPod, nil
+	return &selectedPod, nil
 }