Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for volume level #158

Open
rtritto opened this issue Feb 22, 2025 · 2 comments · May be fixed by #159
Open

Icons for volume level #158

rtritto opened this issue Feb 22, 2025 · 2 comments · May be fixed by #159
Labels
feature New feature or request

Comments

@rtritto
Copy link
Contributor

rtritto commented Feb 22, 2025

If the feature request is for a plugin or provider, specify it here.

No response

If the feature solves a problem you have, specify it here.

Add icons for the volume level

Describe the proposed feature.

An example, with the icons of Video.js from https://videojs.github.io/font:

Image

vLite uses volume-mute and volume-high icons.
The volume-low and volume-mid icons should be added.

Describe alternatives you've considered

No response

Additional context

No response

Related issues

No response

@rtritto rtritto added the feature New feature or request label Feb 22, 2025
@yoriiis
Copy link
Member

yoriiis commented Feb 23, 2025

@rtritto Just so we're aligned, Vlitejs aims to be as minimalist as possible, to keep the core light. This is why the plugin API was created.

For volume management, the player actually offers 2 states (mute, unmute) and a progress bar plugin. If this change is developed, it will be in the core.

I have mixed feelings about adding this changes. It implies loading 1 SVG per state and rethinking management for what I see as a rather limited gain.

I'm not closed to contributions (and I'm happy you contribute to the project), but I'd like to see them go in the same direction as the project. The aim is not to make the core heavier and add multiple features, as has been the case with other libraries (Video.js, Plyrjs) that have become complex over time.

@rtritto rtritto linked a pull request Feb 23, 2025 that will close this issue
6 tasks
@rtritto
Copy link
Contributor Author

rtritto commented Feb 23, 2025

... Vlitejs aims to be as minimalist as possible, to keep the core light.

Agree.

I have mixed feelings about adding this changes. It implies loading 1 SVG per state and rethinking management for what I see as a rather limited gain.

In my opinion, when a volume shortcut (increase/decrease volume) is used, the user should know that the volume was changed: the volume icon should be the right way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants