Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Red component" when volume bar is closing #149

Open
rtritto opened this issue Feb 17, 2025 · 6 comments
Open

"Red component" when volume bar is closing #149

rtritto opened this issue Feb 17, 2025 · 6 comments
Labels
bug Something isn't working

Comments

@rtritto
Copy link
Contributor

rtritto commented Feb 17, 2025

Describe the bug

When the volume bar is closing, a "red component" is displayed near the end of volume bar.

Steps to reproduce

  1. Register the volume-bar plugin
  2. Move the cursor over the volume icon and wait the volume bar is displayed
  3. Remove the cursor from the volume bar
  4. At the end of volume bar, see on top a "red component"

Expected behavior

No "red component" appear when the volume bar is closing

Screenshots and recordings

Image

2025-02-17.221506.mp4

Vlite.js

7.0.0

Browser

Firefox 135

OS

Windows 11

Additional context

No response

@rtritto rtritto added the bug Something isn't working label Feb 17, 2025
@yoriiis
Copy link
Member

yoriiis commented Feb 18, 2025

Thank you @rtritto for the issue problem. Would you like to try and solve it?

@rtritto
Copy link
Contributor Author

rtritto commented Feb 18, 2025

The issue should be on transition of

&-volumeBar {
transition: width var(--vlite-transition), margin var(--vlite-transition);
overflow: hidden;
width: 0;
height: 25px;
&:focus-visible {
width: 52px;
margin-right: 10px;
}
}

Do you have any idea to fix?

@rtritto
Copy link
Contributor Author

rtritto commented Feb 19, 2025

This issue should be in the CSS of v-progressBarStyle class in the input element.
To see the volume bar point (thumb) and test the related CSS, disable/remove overflow: hidden from v-volumeBar class in the input element.

@yoriiis
Copy link
Member

yoriiis commented Feb 20, 2025

It seems related to the input type range element, I don't reproduce the problem on Chrome but in Firefox I see the problem.

I tested quickly but I didn't find a fix, it would be necessary to investigate, but it's quite minimal as a bug and I'm not very available

@rtritto
Copy link
Contributor Author

rtritto commented Feb 22, 2025

We can use same implementation of video.js. Demo: https://videojs.com/advanced/?video=disneys-oceans

@yoriiis
Copy link
Member

yoriiis commented Feb 22, 2025

We can use same implementation of video.js. Demo: https://videojs.com/advanced/?video=disneys-oceans

The Video.js implementation is different and I find the Vlitejs one better, it uses the native hover state in CSS and a range type input (it's inspired by Youtube).

I think a CSS fix might be possible, something like white-space: nowrap or flex-wrap: nowrap but I haven't managed it quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants