Updates to ESLint setup

Author: vjee

config/tsconfig/base.json

@@ -10,6 +10,7 @@
 		"lib": ["dom", "es2022"],
 		"module": "es2022",
 		"moduleResolution": "node",
+		"noEmit": true,
 		"noUnusedLocals": false,
 		"noUnusedParameters": false,
 		"preserveWatchOutput": true,

eslint.config.mjs

@@ -1,4 +1,4 @@
-import {defineConfig, globalIgnores} from 'eslint/config'
+import {defineConfig} from 'eslint/config'
 import globals from 'globals'
 import jsPlugin from '@eslint/js'
 import tsPlugin from 'typescript-eslint'
@@ -7,56 +7,43 @@ import prettierPlugin from 'eslint-plugin-prettier/recommended'
 
 export default defineConfig([
 	{
-		files: ['**/*.{js,mjs,cjs,ts,jsx,tsx}'],
+		name: 'global ignores',
+		ignores: ['**/coverage/**/*', '**/dist/**/*', 'docs/.vitepress/dist/**/*', 'docs/.vitepress/cache/**/*'],
 	},
 
-	globalIgnores(['**/coverage/**/*', '**/dist/**/*', 'docs/.vitepress/dist/**/*', 'docs/.vitepress/cache/**/*']),
+	{
+		name: 'js recommended',
+		...jsPlugin.configs.recommended,
+	},
 
-	jsPlugin.configs.recommended,
+	...tsPlugin.configs.recommendedTypeChecked,
 
 	{
-		files: ['examples/react/**/*.{ts,tsx}'],
-		languageOptions: {
-			parserOptions: {
-				project: 'examples/react/tsconfig.eslint.json',
-				tsconfigRootDir: import.meta.dirname,
-			},
-		},
+		name: 'react recommended',
+		...reactPlugin.configs.flat.recommended,
 	},
 
 	{
-		files: ['packages/core/**/*.{ts,tsx}'],
-		languageOptions: {
-			parserOptions: {
-				project: 'packages/core/tsconfig.eslint.json',
-				tsconfigRootDir: import.meta.dirname,
-			},
-		},
+		name: 'react jsx runtime',
+		...reactPlugin.configs.flat['jsx-runtime'],
 	},
 
+	prettierPlugin,
+
 	{
-		files: ['packages/react/**/*.{ts,tsx}'],
+		name: 'ts configuration',
+		files: ['**/*.{ts,tsx}'],
 		languageOptions: {
 			parserOptions: {
-				project: 'packages/react/tsconfig.eslint.json',
+				projectService: true,
 				tsconfigRootDir: import.meta.dirname,
 			},
 		},
-	},
-
-	...tsPlugin.configs.recommendedTypeChecked.map(config => ({
-		...config,
-		files: ['**/*.{ts,tsx}'],
 		rules: {
 			'no-unused-vars': 'off',
 
 			'@typescript-eslint/consistent-type-imports': 'error',
 			'@typescript-eslint/consistent-type-exports': 'error',
-			'@typescript-eslint/no-unsafe-assignment': 'off',
-			'@typescript-eslint/no-unsafe-return': 'off',
-			'@typescript-eslint/no-unsafe-member-access': 'off',
-			'@typescript-eslint/no-unsafe-argument': 'off',
-			'@typescript-eslint/no-explicit-any': 'off',
 			'@typescript-eslint/no-unused-vars': [
 				'error',
 				{
@@ -66,14 +53,11 @@ export default defineConfig([
 				},
 			],
 		},
-	})),
-
-	reactPlugin.configs.flat.recommended,
-	reactPlugin.configs.flat['jsx-runtime'],
-
-	prettierPlugin,
+	},
 
 	{
+		name: 'global configuration',
+
 		languageOptions: {
 			...reactPlugin.configs.flat.recommended.languageOptions,
 

examples/react/tsconfig.eslint.json

@@ -1,6 +1,6 @@
 {
 	"extends": "@formulier/tsconfig/base",
-	"include": ["src/**/*"],
+	"include": ["src/**/*", "vite.config.ts"],
 	"compilerOptions": {
 		"jsx": "react-jsx"
 	}

examples/react/tsconfig.json

@@ -34,9 +34,9 @@
 		"types": "./dist/index.d.ts"
 	},
 	"scripts": {
-		"build": "tsc",
-		"dev": "tsup --watch",
-		"typecheck": "tsc --noEmit",
+		"build": "tsc --project tsconfig.build.json",
+		"dev": "tsup --project tsconfig.build.json --watch",
+		"typecheck": "tsc",
 		"test": "vitest run",
 		"coverage": "vitest run --coverage"
 	},

packages/core/package.json

@@ -1,6 +1,11 @@
 import clone from 'shallow-clone'
 import isEqual from 'lodash.isequal'
 
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */
+/* eslint-disable @typescript-eslint/no-unsafe-return */
+/* eslint-disable @typescript-eslint/no-unsafe-assignment */
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
 // Originally taken from https://github.com/jaredpalmer/formik/blob/master/packages/formik/src/utils.ts
 function getPath(source: any, path: string | string[], fallback?: any) {
 	let p = 0
@@ -50,6 +55,11 @@ function setPath(obj: any, path: string, value: any): any {
 	return res
 }
 
+/* eslint-enable @typescript-eslint/no-unsafe-member-access */
+/* eslint-enable @typescript-eslint/no-unsafe-return */
+/* eslint-enable @typescript-eslint/no-unsafe-assignment */
+/* eslint-enable @typescript-eslint/no-explicit-any */
+
 function setKey<T extends Record<string, unknown>>(source: T, key: string, value: unknown): T {
 	if (isEqual(source[key], value)) {
 		return source

packages/core/src/state-utils.ts

@@ -0,0 +1,8 @@
+{
+	"extends": "@formulier/tsconfig/base",
+	"include": ["src/**/*"],
+	"compilerOptions": {
+		"noEmit": false,
+		"outDir": "dist"
+	}
+}

packages/core/tsconfig.build.json

@@ -1,8 +1,7 @@
 {
 	"extends": "@formulier/tsconfig/base",
-	"include": ["src/**/*"],
+	"include": ["src/**/*", "tests/**/*", "vitest.config.ts"],
 	"compilerOptions": {
-		"outDir": "dist",
 		"types": ["vitest/importMeta"]
 	}
 }

packages/core/tsconfig.eslint.json

@@ -40,9 +40,9 @@
 		"types": "./dist/index.d.ts"
 	},
 	"scripts": {
-		"build": "tsc",
-		"dev": "tsup --watch",
-		"typecheck": "tsc --noEmit",
+		"build": "tsc --project tsconfig.build.json",
+		"dev": "tsup --project tsconfig.build.json --watch",
+		"typecheck": "tsc",
 		"test": "vitest run",
 		"coverage": "vitest run --coverage",
 		"e2e": "cypress run --component --browser chrome"