Firefox support?

[ian-h-chamberlain]

Hello,

It seems Firefox is mostly compatible with Chrome extensions, so it might not be too difficult to make the browser extension part of this fork compatible with Firefox.

I followed some of the instructions here and was presented with this list of warnings:

{
  "compat": [],
  "errors": [],
  "warnings": [
    {
      "message": "extension.getURL is deprecated",
      "description": "This API has been deprecated by Firefox.",
      "locations": [
        {
          "file": "shared/utils.js",
          "line": 215
        }
      ]
    },
    {
      "message": "addEventListener` called with truthy fourth argument.",
      "description": "When called with a truthy forth argument, listeners can be triggered potentially unsafely by untrusted code. This requires careful review.",
      "locations": [
        {
          "file": "shared/eventsController.js",
          "line": 4
        },
        {
          "file": "shared/content.js",
          "line": 481
        }
      ]
    },
    {
      "message": "eval can be harmful.",
      "description": "Evaluation of strings as code can lead to security vulnerabilities and performance issues, even in the most innocuous of circumstances. Please avoid using `eval` and the `Function` constructor when at all possible.'",
      "locations": [
        {
          "file": "shared/eventsController.js",
          "line": 49
        },
        {
          "file": "shared/content.js",
          "line": 231
        },
        {
          "file": "shared/content.js",
          "line": 349
        }
      ]
    }
  ]
}

It seems that with a bit of work it should be possible to meet the Firefox standards for extensions and create a compatible version. Is this something you'd be interested in?

[ian-h-chamberlain]

Some existing discussion exists on the beardedspice repo regarding this: beardedspice/beardedspice#942

However, I'm not sure if that is still relevant in the context of this repo, or newer Firefox versions (media keys work by default in Firefox now as far as I am aware).