fix: stop hanging project typechecks - #11064
Open
christopher-buss wants to merge 2 commits into
Open
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #9494 -
vitest runhanging after successful project typechecking and leaving an orphanedtscortsgo --watchprocess.Project configs previously resolved
watchfromconfigDefaultsinstead of inheriting the root configuration. In an interactive terminal, this producedwatch: falseat the root butwatch: truein the project, causing the typechecker to start in watch mode duringvitest run.This PR:
watchvalue to project configsThe terminal-specific behavior was also verified using a forced interactive-terminal reproduction. After the fix, both root and project resolve
watch: false, Vitest exits normally, and no watched typechecker process remains.AI-assisted by Codex and reviewed using Claude Opus + a human (myself)!
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.